Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes includes changes from too many versions for react-hot-loader #3330

Closed
edmorley opened this issue Mar 8, 2019 · 9 comments
Closed

Comments

@edmorley
Copy link
Contributor

edmorley commented Mar 8, 2019

What Renovate type are you using?
Renovate GitHub App

Describe the bug
The Renovate PR "Release Notes" section for mozilla/treeherder/pull/4767 includes more versions than is updated by the PR.

Specifically: The PR updates react-hot-loader from 4.7.2 to 4.8.0, however the release notes section also includes changes for 4.7.1 and 4.7.2. (CC @sarah-clements)

Did you see anything helpful in debug logs?
N/A

To Reproduce
Steps to reproduce the behavior:

  1. Look at release notes section on Update dependency react-hot-loader to v4.8.0 mozilla/treeherder#4767

Expected behavior
That "release notes" only include the changes for 4.8.0, since it's the only new version since the existing version.

Many thanks :-)

@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2019

I noticed this the other day. It's breaking our changelog parser because they are using h1 headings for minor releases and h2 for patches:

image

I was thinking to ask them if they'd consider not doing that, as I haven't seen it done before and it makes parsing the changelog pretty close to impossible unless I hardcode a rule in just for their repo.

Have you seen anything like it before and do you think it's "fair" to suggest to them to normalize their headings like other repos?

@rarkins
Copy link
Collaborator

rarkins commented Mar 8, 2019

By the way it's kind of a fluke that the changelog you see is so close to what you need. In Renovate's eyes, the changelogs for all patch releases are missing so it's just showing you the 4.8.0 changelog, which happens to have embedded all 4.7.x patches too

rarkins referenced this issue in gaearon/react-hot-loader Mar 8, 2019
@edmorley
Copy link
Contributor Author

edmorley commented Mar 8, 2019

Thank you for your reply :-)
Ah yes makes sense given the difference in heading types. I haven't seen that style anywhere else from what I can remember.

@rarkins rarkins added the blocked label Mar 9, 2019
@theKashey
Copy link

Probably you shall look at https://github.com/conventional-changelog/releaser-tools - RHL uses it for changelogs.

@rarkins
Copy link
Collaborator

rarkins commented Mar 9, 2019

@hutson can we get your opinion/expertise here? I’m surprised to see this varying header length as something deliberate rather than accidental.

@rarkins
Copy link
Collaborator

rarkins commented Mar 9, 2019

Actually I’m a little lost. That tool appears to generate GitHub releases and not Changelog.md

@theKashey
Copy link

Ok, so then it's about https://github.com/conventional-changelog/standard-version
Sorry, RHL's pipeline was made not by me, and I am not using the same configuration elsewhere.

@rarkins
Copy link
Collaborator

rarkins commented Mar 9, 2019

Thanks. So it appears it’s definitely not unintended (the conventional changelog repo itself uses h1 for Major and minor and h2 for patch) so we need a way to detect and support it.

@rarkins
Copy link
Collaborator

rarkins commented Mar 30, 2020

I know this issue is older, but let's track this feature in #5181 instead

@rarkins rarkins closed this as completed Mar 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants