-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes includes changes from too many versions for react-hot-loader #3330
Comments
I noticed this the other day. It's breaking our changelog parser because they are using h1 headings for minor releases and h2 for patches: I was thinking to ask them if they'd consider not doing that, as I haven't seen it done before and it makes parsing the changelog pretty close to impossible unless I hardcode a rule in just for their repo. Have you seen anything like it before and do you think it's "fair" to suggest to them to normalize their headings like other repos? |
By the way it's kind of a fluke that the changelog you see is so close to what you need. In Renovate's eyes, the changelogs for all patch releases are missing so it's just showing you the 4.8.0 changelog, which happens to have embedded all 4.7.x patches too |
Thank you for your reply :-) |
Probably you shall look at https://github.com/conventional-changelog/releaser-tools - RHL uses it for changelogs. |
@hutson can we get your opinion/expertise here? I’m surprised to see this varying header length as something deliberate rather than accidental. |
Actually I’m a little lost. That tool appears to generate GitHub releases and not Changelog.md |
Ok, so then it's about https://github.com/conventional-changelog/standard-version |
Thanks. So it appears it’s definitely not unintended (the conventional changelog repo itself uses h1 for Major and minor and h2 for patch) so we need a way to detect and support it. |
I know this issue is older, but let's track this feature in #5181 instead |
What Renovate type are you using?
Renovate GitHub App
Describe the bug
The Renovate PR "Release Notes" section for mozilla/treeherder/pull/4767 includes more versions than is updated by the PR.
Specifically: The PR updates react-hot-loader from
4.7.2
to4.8.0
, however the release notes section also includes changes for4.7.1
and4.7.2
. (CC @sarah-clements)Did you see anything helpful in debug logs?
N/A
To Reproduce
Steps to reproduce the behavior:
Expected behavior
That "release notes" only include the changes for
4.8.0
, since it's the only new version since the existing version.Many thanks :-)
The text was updated successfully, but these errors were encountered: