Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): don't remove char before # #23151

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix(markdown): don't remove char before # #23151

merged 1 commit into from
Jul 5, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 5, 2023

Changes

before the regex replace has removed the first matched char

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from setchy, rarkins and secustor July 5, 2023 04:47
@viceice
Copy link
Member Author

viceice commented Jul 5, 2023

@rarkins do we need to backport this to v35?

@viceice viceice enabled auto-merge July 5, 2023 06:58
@viceice viceice added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit 9bc12da Jul 5, 2023
@viceice viceice deleted the viceice-patch-1 branch July 5, 2023 07:10
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants