fix: adjust AbortSignalLike
to support native AbortSignal
#250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR fixes a bug where
AbortSignalLike
was incompatible with the nativeAbortSignal
type.The following TypeScript error is emitted when using the native
AbortSignal
type:Background
globalThis.fetch
uses anAbortSignal
type within thetypescript/lib/lib.dom.d.ts
module that contains properties not present in the@types/node/globals.d.ts
module. In practice, the wider type from@types/node/global.d.ts
is sufficient and better integrates with real projects.Checklist:
🦆