Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecated] Please use option object instead of name string #487

Closed
deadcoder0904 opened this issue Jul 6, 2022 · 1 comment · Fixed by #489
Closed

[Deprecated] Please use option object instead of name string #487

deadcoder0904 opened this issue Jul 6, 2022 · 1 comment · Fixed by #489

Comments

@deadcoder0904
Copy link

I had to debug to find out what changed when using valtio/utils & I had no idea it was valtio/utils that caused it (I searched for Prisma, Nexus, Next.js for that warning at first) cause there was no indication anywhere it was valtio until i opened Chrome DevTools & located a .mjs file having console warnings of Redux Devtools.

I think a more helpful error message would have been like Next.js:

warn - Fast Refresh had to perform a full reload. Read more: https://nextjs.org/docs/basic-features/fast-refresh#how-it-works

Read more at least tells you it's a Next.js issue.

@dai-shi
Copy link
Member

dai-shi commented Jul 6, 2022

I think I overlooked this. I thought we can easily know the file name and the line number (although transpiled), that causes the message.

Adding a link to a PR/issue would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants