Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division and HrmDivision are the same model/endpoint #669

Open
DannyvdSluijs opened this issue Feb 19, 2025 · 0 comments
Open

Division and HrmDivision are the same model/endpoint #669

DannyvdSluijs opened this issue Feb 19, 2025 · 0 comments

Comments

@DannyvdSluijs
Copy link
Contributor

Division and HrmDivision are the same model/endpoint.

Ever since we've been using the generator to keep this library up to date a duplicate (HrmDivision) got introduced.

Then there is also a SystemDivision class model/endpoint which seems to be related but then again looking at the properties seems to be different in a way. Also from my understanding we should treat them as independent models/endpoints in this library.

I think it would be best to:

  • Ensure that while generating code the HrmDivision and SystemDivision get updated according to their documentation
  • The Division class becomes a class alias for the HrmDivision or empty class extending the HrmDivision with a deprecation notice it will be removed in the next mayor versions

The last point might be counter intuitive as speaking about the term Division in the context of Exact Online people tend to mean the SystemDivision. But since the Division class has been the HrmDivision for over ten years switching them could potentially breaks many integrations.

Alternativly we could deprecate the HrmDivision class and make that a class alias of Division and undo the duplication that way?

Curious about what @remkobrenters and @stephangroen think about this duplication and how to move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant