You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ever since we've been using the generator to keep this library up to date a duplicate (HrmDivision) got introduced.
Then there is also a SystemDivision class model/endpoint which seems to be related but then again looking at the properties seems to be different in a way. Also from my understanding we should treat them as independent models/endpoints in this library.
I think it would be best to:
Ensure that while generating code the HrmDivision and SystemDivision get updated according to their documentation
The Division class becomes a class alias for the HrmDivision or empty class extending the HrmDivision with a deprecation notice it will be removed in the next mayor versions
The last point might be counter intuitive as speaking about the term Division in the context of Exact Online people tend to mean the SystemDivision. But since the Division class has been the HrmDivision for over ten years switching them could potentially breaks many integrations.
Alternativly we could deprecate the HrmDivision class and make that a class alias of Division and undo the duplication that way?
Division and HrmDivision are the same model/endpoint.
Ever since we've been using the generator to keep this library up to date a duplicate (
HrmDivision
) got introduced.Then there is also a
SystemDivision
class model/endpoint which seems to be related but then again looking at the properties seems to be different in a way. Also from my understanding we should treat them as independent models/endpoints in this library.I think it would be best to:
HrmDivision
andSystemDivision
get updated according to their documentationDivision
class becomes aclass alias
for theHrmDivision
or empty class extending theHrmDivision
with a deprecation notice it will be removed in the next mayor versionsThe last point might be counter intuitive as speaking about the term
Division
in the context of Exact Online people tend to mean theSystemDivision
. But since theDivision
class has been theHrmDivision
for over ten years switching them could potentially breaks many integrations.Alternativly we could deprecate the
HrmDivision
class and make that a class alias ofDivision
and undo the duplication that way?Curious about what @remkobrenters and @stephangroen think about this duplication and how to move forward?
The text was updated successfully, but these errors were encountered: