Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the host-service/backend & mandelboxes work for non-GPU instances #5725

Closed
philippemnoel opened this issue Mar 3, 2022 · 1 comment · Fixed by #6987 or #7044
Closed

Make the host-service/backend & mandelboxes work for non-GPU instances #5725

philippemnoel opened this issue Mar 3, 2022 · 1 comment · Fixed by #6987 or #7044
Labels
feature New feature or request priority-2-urgent #2 Priority - We need to fix this bug ASAP 📁 Repo: backend This PR/Issue modifies /backend code 📁 Repo: host-service This PR/Issue modifies /host-service code 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code

Comments

@philippemnoel
Copy link
Owner

philippemnoel commented Mar 3, 2022

Feature Description

Regarding the host-service, from @djsavvy:

I think it’ll require some trivial modifications to run on instances without GPUs. You just need to turn off gpu metrics collection.

Regarding the mandelboxes, from @philippemnoel:

I think we'll need to bring back the dummy virtual display, since we can't use the Nvidia one (I think) in this case. Maybe some conditional logic would be nice, since we should be able to deploy both non-GPU and GPU instances, and know which ones to have the host-service use at runtime automatically

Maybe the best approach is just to deploy and pre-download both on all instances unconditionally, and have the host-service have the logic for deciding which one to spin up based on whether it initializes GPUs or not.

@philippemnoel philippemnoel changed the title Make the host-service/backend work on non-GPU instances Make the host-service/backend & mandelboxes work on non-GPU instances Mar 8, 2022
@philippemnoel philippemnoel changed the title Make the host-service/backend & mandelboxes work on non-GPU instances Make the host-service/backend & mandelboxes work for non-GPU instances Mar 9, 2022
@philippemnoel philippemnoel added feature New feature or request priority-2-urgent #2 Priority - We need to fix this bug ASAP 📁 Repo: backend This PR/Issue modifies /backend code 📁 Repo: host-service This PR/Issue modifies /host-service code 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code labels Mar 9, 2022
@philippemnoel
Copy link
Owner Author

For the host-service, it might be as simple as following what we do for CI, which doesn't have GPUs! See:

		// CI does not have GPUs
		if !metadata.IsRunningInCI() {
			if err := mandelbox.AssignGPU(); err != nil {
				return utils.MakeError("Error assigning GPU: %s", err)
			}
		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request priority-2-urgent #2 Priority - We need to fix this bug ASAP 📁 Repo: backend This PR/Issue modifies /backend code 📁 Repo: host-service This PR/Issue modifies /host-service code 📁 Repo: mandelboxes This PR/Issue modifies /mandelboxes code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant