Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to imageio-ffmpeg #2314

Closed
jkterry1 opened this issue Aug 12, 2021 · 4 comments
Closed

Switch to imageio-ffmpeg #2314

jkterry1 opened this issue Aug 12, 2021 · 4 comments

Comments

@jkterry1
Copy link
Collaborator

Per discussion in PR #1893

@jkterry1
Copy link
Collaborator Author

jkterry1 commented Oct 4, 2021

@zlig does your PR I just merged close this?

@zlig
Copy link
Contributor

zlig commented Oct 4, 2021

I would actually defer to @christopherhesse as it was his original suggestion.

We need to confirm if the intention was to fully switch everything to imageio-ffmpeg, which means there is more work to do, or just add it as an alternative, which means we are done as we did in #1893

@jkterry1
Copy link
Collaborator Author

jkterry1 commented Oct 4, 2021

Christopher Hesse isn't really involved in the maintenance. I'm happy to close this given us supporting both, however a concern that's raised is that the "other" extra in setup.py doesn't include ffmpeg, meaning this alternative rendering method isn't tested. Would you be willing to add a PR that does this?

@zlig
Copy link
Contributor

zlig commented Oct 11, 2021

The missing imageio_ffmpeg component in setup.py would not be exercised with the current build workflows though, would it?

My understanding is we need to run tests via the workflows for various systems with ffmpeg, other with avconv, and finally one for the alternative we just added with imageio-ffmpeg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants