-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to imageio-ffmpeg #2314
Comments
@zlig does your PR I just merged close this? |
I would actually defer to @christopherhesse as it was his original suggestion. We need to confirm if the intention was to fully switch everything to imageio-ffmpeg, which means there is more work to do, or just add it as an alternative, which means we are done as we did in #1893 |
Christopher Hesse isn't really involved in the maintenance. I'm happy to close this given us supporting both, however a concern that's raised is that the "other" extra in setup.py doesn't include ffmpeg, meaning this alternative rendering method isn't tested. Would you be willing to add a PR that does this? |
The missing My understanding is we need to run tests via the workflows for various systems with ffmpeg, other with avconv, and finally one for the alternative we just added with imageio-ffmpeg. |
Per discussion in PR #1893
The text was updated successfully, but these errors were encountered: