Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP "Problems" in VSC/Windows - bad file uri #178

Open
dgriffie79 opened this issue Dec 20, 2024 · 0 comments
Open

LSP "Problems" in VSC/Windows - bad file uri #178

dgriffie79 opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dgriffie79
Copy link
Contributor

The "Problems" panel does isn't working on windows, in that clicking on the problem does not take you to the file location because the file URI is messed up as in the screenshot. This causes an annoying window to open up saying the path isn't valid, rather than jumping to the compile error in the code.

lsp

It looks like there are two issues:

  1. the compiler json output is wrong on windows because it doesn't escape the \ in the file path. You can see this by running onyx check --error-format json and the file paths will not have the \\ as they should for json encoded strings.

  2. the uri with the drive letter is encoded weird, so that it looks like 'file://c:/...' which would be an invalid file URI because C: is not a hostname. This commented out call to uri_encode does fix this issue on windows

@brendanfh brendanfh self-assigned this Dec 26, 2024
@brendanfh brendanfh added this to the v0.1.14 milestone Dec 26, 2024
@brendanfh brendanfh added the bug Something isn't working label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants