Tertiary roll boosts don't apply for sub loot tables

[DayV-git]

🐛 Bug Report

In loot table roll function

oldschoolbot/packages/oldschooljs/src/structures/LootTable.ts

Lines 205 to 284 in d929934

	public roll(quantity = 1, options: LootTableRollOptions = {}): Bank | null {
	const loot = options.targetBank ?? new Bank();
	const effectiveTertiaryItems = options.tertiaryItemPercentageChanges
	? this.tertiaryItems.map(i => {
	if (typeof i.item !== 'number') return i;
	if (i.options?.freeze === true) return i;
	const change = options.tertiaryItemPercentageChanges?.get(Items.get(i.item)!.name);
	if (!change) return i;
	return {
	...i,
	chance: Math.ceil(reduceNumByPercent(i.chance, change))
	};
	})
	: this.tertiaryItems;
	const limit = this.limit || this.totalWeight;
	if (this.table.every(i => Number.isInteger(i.weight)) && this.cachedOptimizedTable === null) {
	this.cachedOptimizedTable = [];
	for (const item of this.table) {
	for (let j = 0; j < item.weight!; j++) {
	this.cachedOptimizedTable.push(this.table.indexOf(item));
	}
	}
	while (this.cachedOptimizedTable.length < limit) {
	this.cachedOptimizedTable.push(-1);
	}
	}
	outerLoop: for (let i = 0; i < quantity; i++) {
	for (let j = 0; j < this.everyItems.length; j++) {
	this.addResultToLoot(this.everyItems[j], loot);
	}
	for (let j = 0; j < effectiveTertiaryItems.length; j++) {
	if (roll(effectiveTertiaryItems[j].chance)) {
	this.addResultToLoot(effectiveTertiaryItems[j], loot);
	}
	}
	for (let j = 0; j < this.oneInItems.length; j++) {
	if (roll(this.oneInItems[j].chance)) {
	this.addResultToLoot(this.oneInItems[j], loot);
	continue outerLoop;
	}
	}
	if (this.cachedOptimizedTable) {
	this.addResultToLoot(this.table[randArrItem(this.cachedOptimizedTable)], loot);
	} else {
	const randomWeight = randFloat(0, limit);
	let weight = 0;
	for (let i = 0; i < this.table.length; i++) {
	weight += this.table[i].weight!;
	if (randomWeight <= weight) {
	this.addResultToLoot(this.table[i], loot);
	break;
	}
	}
	}
	}
	if (!options.targetBank) {
	return loot;
	}
	return null;
	}
	private addResultToLoot(result: LootTableItem, loot: Bank): void {
	if (typeof result?.item === 'number') {
	loot.addItem(result.item, this.determineQuantity(result.quantity));
	return;
	}
	if (result?.item instanceof LootTable) {
	const qty = this.determineQuantity(result.quantity);
	if (result.options?.multiply) loot.add(result.item.roll(1).multiply(qty));
	else result.item.roll(qty, { targetBank: loot });
	return;
	}
	}

LootTableRollOptions is used for updated teritiary items (clues with CAs, row etc) which is passed into LootTable.roll but it isn't passed into the roll functions for any subtables in LootTable.addResultToLoot, so they aren't boosted. Examples are no boosted clue rates from any wildy bosses with ring of wealth (i).