Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lts/* on Travis #1208

Closed
keithamus opened this issue Aug 23, 2016 · 2 comments
Closed

Support lts/* on Travis #1208

keithamus opened this issue Aug 23, 2016 · 2 comments
Assignees
Labels
bugs Oh no, something's broken :-( feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.

Comments

@keithamus
Copy link

Hello all the wonderful contributors of nvm! Thank you for all of your excellent work.

Recently @ljharb added the feature of being able to automatically use lts/<something> as an alias, e.g. nvm use lts/argon. This is really really cool, but as part of the discussion there was some talk about having travis support these kinds of aliases within a .travis.yml, e.g.:

node:
 - lts/argon
 - stable

As far as I know, travis just runs nvm install <yml.node[n]>. I think the coolest way to support this feature would be for nvm install to fall back to local aliases if ls-remote returns N/A, in other words:

Actual

$ nvm install lts/argon
Version 'lts/argon' not found - try `nvm ls-remote` to browse available versions.

Desired

$ nvm install lts/argon
Remote version 'lts/argon' found, falling back to local aliases
lts/argon -> 4.5
Downloading https://nodejs.org/dist/v4.5.0/node-v4.5.0-darwin-x64.tar.xz...
######################################################################## 100.0%
Now using node v4.5.0 (npm v2.15.9)
@ljharb ljharb self-assigned this Aug 23, 2016
@ljharb ljharb added installing node Issues with installing node/io.js versions. feature requests I want a new feature in nvm! bugs Oh no, something's broken :-( labels Aug 23, 2016
@ljharb
Copy link
Member

ljharb commented Aug 23, 2016

I'm going to make it explicitly support lts/* and lts/foo rather than falling back on local aliases (since the local aliases don't exist until after the first remote call is made). The effect will be the same.

@ljharb ljharb closed this as completed in 1ac7e23 Aug 23, 2016
@ljharb
Copy link
Member

ljharb commented Aug 23, 2016

Released in v0.31.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Oh no, something's broken :-( feature requests I want a new feature in nvm! installing node Issues with installing node/io.js versions.
Projects
None yet
Development

No branches or pull requests

2 participants