Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got an error message while installing #1189

Closed
PeterDaveHello opened this issue Aug 4, 2016 · 8 comments
Closed

Got an error message while installing #1189

PeterDaveHello opened this issue Aug 4, 2016 · 8 comments
Labels
bugs Oh no, something's broken :-( installing nvm Problems installing nvm itself

Comments

@PeterDaveHello
Copy link
Collaborator

The good news is nvm still works good.

curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.31.4/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  9135  100  9135    0     0   161k      0 --:--:-- --:--:-- --:--:--  162k
=> Downloading nvm from git to '/home/nitrous/.nvm'
=> Cloning into '/home/nitrous/.nvm'...
remote: Counting objects: 5158, done.
remote: Compressing objects: 100% (13/13), done.
remote: Total 5158 (delta 3), reused 0 (delta 0), pack-reused 5145
Receiving objects: 100% (5158/5158), 1.37 MiB | 886.00 KiB/s, done.
Resolving deltas: 100% (3102/3102), done.
Checking connectivity... done.
* (detached from v0.31.4)
  master

=> Appending source string to /home/peter/.bashrc
bash: line 293: /nvm.sh: No such file or directory
=> Close and reopen your terminal to start using nvm or run the following to use it now:

export NVM_DIR="/home/nitrous/.nvm"
[ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh"  # This loads nvm
@ljharb
Copy link
Member

ljharb commented Aug 4, 2016

@PeterDaveHello do you have NVM_DIR set to something that's not $HOME? What do $NVM_DIR and $HOME contain?

@ljharb ljharb added needs followup We need some info or action from whoever filed this issue/PR. installing nvm Problems installing nvm itself labels Aug 4, 2016
@danielkoo
Copy link

Hi all,

I came across the same issue as well, and it looks as if NVM_DIR has not been set when the script tries to source $NVM_DIR/nvm.sh

In the meantime the workaround is just to source nvm.sh directly (or alternatively, ~/.bashrc)

@ljharb
Copy link
Member

ljharb commented Aug 5, 2016

It seems like perhaps it should be sourcing $INSTALL_DIR/nvm.sh instead?

@danielkoo
Copy link

Yes, that would work too @ljharb, given this shows
export NVM_DIR="$INSTALL_DIR"
the 2 share the same value, even if they might be semantically different.
I'm happy to submit a PR if that's the decision?

@ljharb
Copy link
Member

ljharb commented Aug 5, 2016

Since you can repro it, you can verify that that indeed fixes the issue, so then yes, a PR would be great :-)

@PeterDaveHello
Copy link
Collaborator Author

PeterDaveHello commented Aug 5, 2016

@PeterDaveHello do you have NVM_DIR set to something that's not $HOME? What do $NVM_DIR and $HOME contain?

@ljharb nope, I didn't set anything manully, it's from a clean Ubuntu 14.04 environment.

@PeterDaveHello
Copy link
Collaborator Author

I'm now working on the PR.

@ljharb ljharb closed this as completed in 88fc93a Aug 5, 2016
@danielkoo
Copy link

I just tested it, and can verify it's working fine now. Thanks guys.

@ljharb ljharb added bugs Oh no, something's broken :-( and removed needs followup We need some info or action from whoever filed this issue/PR. labels Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Oh no, something's broken :-( installing nvm Problems installing nvm itself
Projects
None yet
Development

No branches or pull requests

3 participants