Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook fix no longer works because of appType change #500

Open
lukereative opened this issue Feb 13, 2025 · 0 comments
Open

Storybook fix no longer works because of appType change #500

lukereative opened this issue Feb 13, 2025 · 0 comments

Comments

@lukereative
Copy link

lukereative commented Feb 13, 2025

Storybook changed which appType was used in it's vitebuilder to be 'custom' – storybookjs/builder-vite#453 which causes the check within the workaround plugin to not work.

      if (server.config.appType !== 'custom') {

This means that the fonts aren't loading in storybook.

The workaround that I'm using at the moment is putting this in my storybook config:

viteFinal: async (config) => {
    config.appType = 'spa';

  return config;
},

But I don't think that's a long term fix, I think a new check will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant