Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Support Coil image loader #166

Closed
ZacSweers opened this issue Sep 16, 2019 · 2 comments
Closed

Feature request: Support Coil image loader #166

ZacSweers opened this issue Sep 16, 2019 · 2 comments
Labels
enhancement

Comments

@ZacSweers
Copy link

Coil is a new and popular image loading library for android. It would be great if Markwon offered a first party artifact, though it may be more difficult since Coil is a Kotlin-first API
@noties
Copy link
Owner

noties commented Sep 16, 2019

Hello @ZacSweers !

I didn't have plans to extend a list of supported image loaders. After all there is a really cool markwon-image module 😉 ! But if anyone wants to implement an image loader based on Coil, I would gladly review pull request or add this artifact in the awesome section (in case of independent project)

@tylerbwong tylerbwong mentioned this issue Nov 13, 2019
Merged
@noties noties mentioned this issue Nov 15, 2019
Merged
@noties
Copy link
Owner

noties commented Nov 15, 2019

Shipping with 4.2.0 release, thanks @tylerbwong 🙌

@noties noties closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZacSweers @noties