fix(deepMerge): support copying Buffers

fixes #268
noodlefrenzy · Oct 19, 2016 · db6295f · db6295f
1 parent 00afee0
commit db6295f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/utilities.js b/lib/utilities.js
@@ -117,11 +117,16 @@ function deepMerge() {
       s2 = src;
     } else {
       if (!tgt[key]) {
-        tgt[key] = new src[key].constructor();
+        if (src[key] instanceof Buffer) {
+          tgt[key] = new Buffer(src[key]);
+        } else {
+          tgt[key] = new src[key].constructor();
+        }
       }
       t2 = tgt[key];
       s2 = src[key];
     }
+
     for (var k2 in s2) {
       if (s2.hasOwnProperty(k2)) {
         var v2 = s2[k2];

diff --git a/test/unit/test_utilities.js b/test/unit/test_utilities.js
@@ -81,6 +81,11 @@ describe('Utilities', function() {
       expect(merged).to.eql({ foo: { bar: 1, baz: 2, zoop: 1 }, bat: 3, dubin: { a: 1 }});
     });
 
+    it('should work with Buffers', function() {
+      var merged = u.deepMerge({}, { test: new Buffer([0xDE, 0xAD, 0xBE, 0xEF]) });
+      expect(merged.test).to.eql(new Buffer([0xDE, 0xAD, 0xBE, 0xEF]));
+    });
+
     // @todo Fix deepMerge to preserve object __proto__ identity.
     // it('should work for nested with custom types', function() {
     //   var nested = { foo: { bar: new AMQPSymbol('s1') } };