fix(canSend): move state check to canSend based on review

noodlefrenzy · Aug 3, 2015 · 06e0edc · 06e0edc
1 parent c66b0f0
commit 06e0edc
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/sender_link.js b/lib/sender_link.js
@@ -33,7 +33,12 @@ SenderLink.prototype.attach = function() {
 };
 
 SenderLink.prototype.canSend = function() {
-  var sendable = (this.linkCredit >= 1 && (!this.session.policy.enableSessionFlowControl || this.session._sessionParams.remoteIncomingWindow >= 1));
+  if (this.state() !== 'attached') {
+    return false;
+  }
+
+  var sendable = this.linkCredit >= 1 &&
+    (!this.session.policy.enableSessionFlowControl || this.session._sessionParams.remoteIncomingWindow >= 1);
   debug('canSend(' + this.linkCredit + ',' + this.session._sessionParams.remoteIncomingWindow + ') = ' + sendable);
   return sendable;
 };
@@ -89,7 +94,7 @@ SenderLink.prototype.send = function(msg, options) {
       }
     };
 
-    if (self.state() !== 'attached' || !self.canSend()) {
+    if (!self.canSend()) {
       self._pendingSends.push(sendMessage);
       return;
     }