From bb77cce7a17f043867419d3698ace3c210ff220d Mon Sep 17 00:00:00 2001 From: Eugene Ostroukhov Date: Wed, 24 May 2017 10:04:39 -0700 Subject: [PATCH] inspector: add missing virtual destructor This fixes a resource leak detected by a Coverity scan. PR-URL: https://github.com/nodejs/node/pull/13198 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell Reviewed-By: Aleksei Koziatinskii --- src/inspector_agent.cc | 2 +- src/inspector_agent.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index c93aab4eafce04..5af395453c04cc 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate { v8::WeakCallbackType::kParameter); } - virtual ~JsBindingsSessionDelegate() { + ~JsBindingsSessionDelegate() override { session_.Reset(); receiver_.Reset(); callback_.Reset(); diff --git a/src/inspector_agent.h b/src/inspector_agent.h index 08c4af9a9cc458..2bc65f76640261 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -37,6 +37,7 @@ namespace inspector { class InspectorSessionDelegate { public: + virtual ~InspectorSessionDelegate() = default; virtual bool WaitForFrontendMessage() = 0; virtual void OnMessage(const v8_inspector::StringView& message) = 0; };