.dump() not allowing compact form

[qikdauie]

When trying to use dump(-1) or dump(), it is producing the effects of dump(0)

Please describe the steps to reproduce the issue.

use dump(-1) or dump(), it will add newlines.

Can you provide a small but working code example?

json obj { {"a", "ayyy"}, {"b", "beee"} } std::cout << obj.dump(-1);
output:
{\n "a": "ayyy",\n "b": "beee"\n }\n

What is the expected behavior?

{"a": "ayyy","b": "beee"}

In json.hpp starting a line 2236, the conditions here do not allow for -1 mode.
if (indent >= 0) { s.dump(*this, true, ensure_ascii, static_cast<unsigned int>(indent)); } else { s.dump(*this, false, ensure_ascii, 0); }

• Compiler: cl
• Operating system: mac

Which version of the library did you use?

• [x ] latest release version 3.9.1
• other release - please state the version: ___
• the develop branch

If you experience a compilation error: can you compile and run the unit tests?

• yes
• [ x] no - please copy/paste the error message below

[qikdauie]

Im just going to alter my copy of the lib, but, was this disabled for some reason?

[qikdauie]

if anyone is having this issue, a workaround is a compact function using regex. Here's mine if you're interested:

std::string CompactJsonString(std::string& json) { std::regex no_space("\\s(?=([^\"]*\"[^\"]*\")*[^\"]*$)"); std::regex no_newline("\\s\n(?=([^\"]*\"[^\"]*\")*[^\"]*$)"); // write the results to an output iterator json = std::regex_replace(json, no_space, ""); json = std::regex_replace(json, no_newline, ""); return json; }

[t-b]

@qikdauie Do the tests pass on your platform?

From the test code at

json/test/src/unit-inspection.cpp

Lines 228 to 235 in 176d8e2

	SECTION("no indent / indent=-1")
	{
	CHECK(j.dump() ==
	"{\"array\":[1,2,3,4],\"boolean\":false,\"null\":null,\"number\":42,\"object\":{},\"string\":\"Hello world\"}");
	CHECK(j.dump() == j.dump(-1));
	}

it looks like dump does what you expect.

[qikdauie]

@t-b on a deadline at the moment. Ill test asap and get back to the thread. Thanks for the response.

[nlohmann]

I cannot reproduce the issue. The code for serialization is unchanged for months and part of the unit tests. Please provide a small working example. Please also check if the test suite passes.