Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linker error #2292

Closed
ferencdg opened this issue Jul 19, 2020 · 2 comments · Fixed by #2285
Closed

linker error #2292

ferencdg opened this issue Jul 19, 2020 · 2 comments · Fixed by #2285
Assignees
@nlohmann
Labels
kind: bug release item: 🐛 bug fix solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.9.0

Comments

@ferencdg
Copy link

hi, can you please make the
std::size_t combine(std::size_t seed, std::size_t h) noexcept
function inline?

I am getting linker errors as I am using your .hpp from 2 different library
@nlohmann
Copy link
Owner

Should be fixed with #2285.

@nlohmann nlohmann self-assigned this Jul 19, 2020
@nlohmann nlohmann added release item: 🐛 bug fix solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Jul 19, 2020
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 19, 2020
@nlohmann
Copy link
Owner

Fixed.

@nlohmann nlohmann linked a pull request Jul 19, 2020 that will close this issue
add inline specifier for detail::combine #2285
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: bug release item: 🐛 bug fix solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging a pull request may close this issue.

add inline specifier for detail::combine T0b1-iOS/json
2 participants
@nlohmann @ferencdg