Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler Errors under VS2019 in Appveyor CI #2009

Closed
dota17 opened this issue Mar 25, 2020 · 4 comments
Closed

Compiler Errors under VS2019 in Appveyor CI #2009

dota17 opened this issue Mar 25, 2020 · 4 comments
Labels
kind: bug platform: visual studio related to MSVC release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone

Comments

@dota17
Copy link
Contributor

dota17 commented Mar 25, 2020

Recently, Appveyor CI had a lot of compiler errors under VS2019.
Since 3/20, all pr have the same compiler errors:

C:\projects\json\test\src\unit-conversions.cpp(1387): message : see reference to function template instantiation 'ValueType nlohmann::basic_json<std::map,std::vector,std::string,bool,int64_t,uint64_t,double,std::allocator,nlohmann::adl_serializer>::get<std::valarray<std::string>,std::valarray<std::string>,0>(void) noexcept(false) const' being compiled [C:\projects\json\test\test-conversions.vcxproj]
          with
          [
              ValueType=std::valarray<std::string>
          ]
...

#2004 just added wsjcpp.yml, and it got the same errors.

  • What is the expected behavior?
    Appveyor CI should pass.
@garethsb
Copy link
Contributor

Resolved by #2008, I think?

@dota17
Copy link
Contributor Author

dota17 commented Mar 26, 2020

Resolved by #2008, I think?

Yes, I had checked and tested in my fork repo.
After merging the PR, the Appveyor CI will pass.

Thanks for your help : ) .
This issue can be closed when the PR #2008 is merged.

@nlohmann
Copy link
Owner

nlohmann commented Apr 5, 2020

#2008 was merged. Any ideas on this?

@dota17
Copy link
Contributor Author

dota17 commented Apr 7, 2020

No. This issue can be closed.

@dota17 dota17 closed this as completed Apr 7, 2020
@nlohmann nlohmann added platform: visual studio related to MSVC release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation labels Apr 10, 2020
@nlohmann nlohmann added this to the Release 3.7.4 milestone Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug platform: visual studio related to MSVC release item: 🔨 further change solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Development

No branches or pull requests

3 participants