Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation failure using Clang on Windows #1898

Closed
jabra11 opened this issue Jan 10, 2020 · 5 comments · Fixed by #2259
Closed

Compilation failure using Clang on Windows #1898

jabra11 opened this issue Jan 10, 2020 · 5 comments · Fixed by #2259
Assignees
@nlohmann
Labels
kind: bug release item: ⚡ improvement solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Milestone
Release 3.9.0

Comments

@jabra11
Copy link

jabra11 commented Jan 10, 2020 •
edited
Loading

Hi, the compilation fails when using Clang on Windows. I have used Ninja as my Generator and this is the cmake --build output: https://pastebin.com/fWASC8cV
It compiles when using msvc. I also tried to change the if logic in the CMakeLists.txt in the root to include Clang to the MSVC specific settings. Didn't do anything though.
@stale
Copy link

stale bot commented Feb 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Feb 9, 2020
@stale stale bot closed this as completed Feb 16, 2020
@dota17
Copy link
Contributor

dota17 commented Mar 10, 2020

Can you tell how you build this library with clang on windows?
Or you can show your CMakeLists.txt.

I had tried many ways to build with clang on windows, but fail.
Now, I am not sure whether it can build with clang on windows?Does it support?

@tawmoto
Copy link

tawmoto commented May 29, 2020 •
edited
Loading

@dota17 I am also interested to find out this answer, thanks, does it work with clang on windows?

@nlohmann
Copy link
Owner

See #1818 (comment) - trying to reproduce.

@tawmoto tawmoto mentioned this issue Jun 4, 2020
Closed
@nlohmann nlohmann self-assigned this Jul 11, 2020
@nlohmann nlohmann reopened this Jul 11, 2020
@stale stale bot removed the state: stale the issue has not been updated in a while and will be closed automatically soon unless it is updated label Jul 11, 2020
@nlohmann
Copy link
Owner

To be fixed with #2259.

@nlohmann nlohmann added the solution: proposed fix a fix for the issue has been proposed and waits for confirmation label Jul 11, 2020
@nlohmann nlohmann mentioned this issue Jul 11, 2020
Merged
@nlohmann nlohmann added this to the Release 3.8.1 milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlohmann nlohmann

Labels
kind: bug release item: ⚡ improvement solution: proposed fix a fix for the issue has been proposed and waits for confirmation
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging a pull request may close this issue.

Make library work with Clang on Windows nlohmann/json
4 participants
@nlohmann @jabra11 @tawmoto @dota17