Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "skip" option to subscription hook #1225

Closed
brianjd opened this issue Jan 3, 2025 · 2 comments · Fixed by #1229
Closed

Add "skip" option to subscription hook #1225

brianjd opened this issue Jan 3, 2025 · 2 comments · Fixed by #1229
Labels
feature New feature or request

Comments

@brianjd
Copy link
Contributor

brianjd commented Jan 3, 2025

Description

Add skip option to 'useSubscription' hook.

Suggested implementation

Add option, default to false. If true, early return before creating observable.
@brianjd brianjd added the feature New feature or request label Jan 3, 2025
@brianjd
Copy link
Contributor Author

brianjd commented Jan 7, 2025

cc: @simoneb

Is there a discussion to be had or just proceed with PR?

@simoneb
Copy link
Member

simoneb commented Jan 7, 2025

feel free to create a PR if you know already how to implement your proposal!

@brianjd brianjd mentioned this issue Jan 7, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: skip option for subscription brianjd/graphql-hooks
3 participants
@simoneb @brianjd and others