-
Notifications
You must be signed in to change notification settings - Fork 8
/
Copy pathmiddleware_test.go
639 lines (601 loc) · 17.8 KB
/
middleware_test.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
package kocha_test
import (
"bytes"
"fmt"
"io"
"mime/multipart"
"net/http"
"net/http/httptest"
"reflect"
"strings"
"testing"
"time"
"github.com/naoina/kocha"
"github.com/naoina/kocha/log"
"github.com/naoina/kocha/util"
)
func TestPanicRecoverMiddleware(t *testing.T) {
test := func(ident string, w *httptest.ResponseRecorder) {
var actual interface{} = w.Code
var expect interface{} = http.StatusInternalServerError
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: %s; status => %#v; want %#v`, ident, actual, expect)
}
actual = w.Body.String()
expect = "This is layout\n500 error\n\n"
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: %s => %#v; want %#v`, ident, actual, expect)
}
actual = w.Header().Get("Content-Type")
expect = "text/html"
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: %s; Context-Type => %#v; want %#v`, ident, actual, expect)
}
}
func() {
req, err := http.NewRequest("GET", "/error", nil)
if err != nil {
t.Fatal(err)
}
app := kocha.NewTestApp()
app.Config.Middlewares = []kocha.Middleware{
&kocha.PanicRecoverMiddleware{},
&kocha.DispatchMiddleware{},
}
var buf bytes.Buffer
app.Logger = log.New(&buf, &log.LTSVFormatter{}, app.Config.Logger.Level)
w := httptest.NewRecorder()
app.ServeHTTP(w, req)
test(`GET "/error"`, w)
actual := strings.SplitN(buf.String(), "\n", 2)[0]
expect := "\tmessage:panic test"
if !strings.Contains(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: GET "/error"; log => %#v; want contains => %#v`, actual, expect)
}
}()
func() {
req, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
app := kocha.NewTestApp()
app.Config.Middlewares = []kocha.Middleware{
&kocha.PanicRecoverMiddleware{},
&TestPanicInBeforeMiddleware{},
&kocha.DispatchMiddleware{},
}
var buf bytes.Buffer
app.Logger = log.New(&buf, &log.LTSVFormatter{}, app.Config.Logger.Level)
w := httptest.NewRecorder()
app.ServeHTTP(w, req)
test(`GET "/"`, w)
actual := strings.SplitN(buf.String(), "\n", 2)[0]
expect := "\tmessage:before"
if !strings.Contains(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: GET "/error"; log => %#v; want contains => %#v`, actual, expect)
}
}()
func() {
req, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
app := kocha.NewTestApp()
app.Config.Middlewares = []kocha.Middleware{
&kocha.PanicRecoverMiddleware{},
&TestPanicInAfterMiddleware{},
&kocha.DispatchMiddleware{},
}
var buf bytes.Buffer
app.Logger = log.New(&buf, &log.LTSVFormatter{}, app.Config.Logger.Level)
w := httptest.NewRecorder()
app.ServeHTTP(w, req)
test(`GET "/"`, w)
actual := strings.SplitN(buf.String(), "\n", 2)[0]
expect := "\tmessage:after"
if !strings.Contains(actual, expect) {
t.Errorf(`PanicRecoverMiddleware: GET "/error"; log => %#v; want contains => %#v`, actual, expect)
}
}()
func() {
defer func() {
actual := recover()
expect := "before"
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`PanicRecoverMiddleware after panic middleware: GET "/" => %#v; want %#v`, actual, expect)
}
}()
req, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
app := kocha.NewTestApp()
app.Config.Middlewares = []kocha.Middleware{
&TestPanicInBeforeMiddleware{},
&kocha.PanicRecoverMiddleware{},
&kocha.DispatchMiddleware{},
}
w := httptest.NewRecorder()
app.ServeHTTP(w, req)
}()
func() {
defer func() {
actual := recover()
expect := "after"
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`PanicRecoverMiddleware after panic middleware: GET "/" => %#v; want %#v`, actual, expect)
}
}()
req, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
app := kocha.NewTestApp()
app.Config.Middlewares = []kocha.Middleware{
&TestPanicInAfterMiddleware{},
&kocha.PanicRecoverMiddleware{},
&kocha.DispatchMiddleware{},
}
w := httptest.NewRecorder()
app.ServeHTTP(w, req)
}()
}
func TestFormMiddleware(t *testing.T) {
doTest := func(body io.Reader, contentType string) {
app := kocha.NewTestApp()
r, err := http.NewRequest("POST", "/?q=test&t=jp", body)
if err != nil {
t.Fatal(err)
}
r.Header.Set("Content-Type", contentType)
req, res := &kocha.Request{Request: r}, &kocha.Response{ResponseWriter: httptest.NewRecorder()}
c := &kocha.Context{
Request: req,
Response: res,
}
m := &kocha.FormMiddleware{}
if err := m.Process(app, c, func() error {
var actual interface{} = c.Params.Encode()
var expect interface{} = "f=bob&n=alice&q=test&t=jp"
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`FormMiddleware.Process(app, c, func); c.Params => %#v; want %#v`, actual, expect)
}
return nil
}); err != nil {
t.Fatal(err)
}
}
// test with x-www-form-urlencoded
func() {
doTest(bytes.NewBufferString("n=alice&f=bob"), "application/x-www-form-urlencoded")
}()
// test with multipart/form-data
func() {
var body bytes.Buffer
w := multipart.NewWriter(&body)
for _, v := range [][2]string{
{"n", "alice"},
{"f", "bob"},
} {
if err := w.WriteField(v[0], v[1]); err != nil {
t.Fatal(err)
}
}
w.Close()
doTest(&body, w.FormDataContentType())
}()
}
func newTestSessionMiddleware(store kocha.SessionStore) *kocha.SessionMiddleware {
return &kocha.SessionMiddleware{
Name: "test_session",
Store: store,
ExpiresKey: "test.expires.key",
}
}
func TestSessionMiddleware_Before(t *testing.T) {
newRequestResponse := func(cookie *http.Cookie) (*kocha.Request, *kocha.Response) {
r, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
req := &kocha.Request{Request: r}
if cookie != nil {
req.AddCookie(cookie)
}
res := &kocha.Response{ResponseWriter: httptest.NewRecorder()}
return req, res
}
origNow := util.Now
util.Now = func() time.Time { return time.Unix(1383820443, 0) }
defer func() {
util.Now = origNow
}()
// test new session
func() {
app := kocha.NewTestApp()
req, res := newRequestResponse(nil)
c := &kocha.Context{Request: req, Response: res}
m := &kocha.SessionMiddleware{Store: &NullSessionStore{}}
err := m.Process(app, c, func() error {
actual := c.Session
expected := make(kocha.Session)
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Session
expect = make(kocha.Session)
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
}()
// test expires not found
func() {
app := kocha.NewTestApp()
store := kocha.NewTestSessionCookieStore()
sess := make(kocha.Session)
value, err := store.Save(sess)
if err != nil {
t.Fatal(err)
}
m := newTestSessionMiddleware(store)
cookie := &http.Cookie{
Name: m.Name,
Value: value,
}
req, res := newRequestResponse(cookie)
c := &kocha.Context{Request: req, Response: res}
err = m.Process(app, c, func() error {
actual := c.Session
expected := make(kocha.Session)
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Session
expect = make(kocha.Session)
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
}()
// test expires invalid time format
func() {
app := kocha.NewTestApp()
store := kocha.NewTestSessionCookieStore()
m := newTestSessionMiddleware(store)
sess := make(kocha.Session)
sess[m.ExpiresKey] = "invalid format"
value, err := store.Save(sess)
if err != nil {
t.Fatal(err)
}
cookie := &http.Cookie{
Name: m.Name,
Value: value,
}
req, res := newRequestResponse(cookie)
c := &kocha.Context{Request: req, Response: res}
err = m.Process(app, c, func() error {
actual := c.Session
expect := make(kocha.Session)
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Session
expect = make(kocha.Session)
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
}()
// test expired
func() {
app := kocha.NewTestApp()
store := kocha.NewTestSessionCookieStore()
m := newTestSessionMiddleware(store)
sess := make(kocha.Session)
sess[m.ExpiresKey] = "1383820442"
value, err := store.Save(sess)
if err != nil {
t.Fatal(err)
}
cookie := &http.Cookie{
Name: m.Name,
Value: value,
}
req, res := newRequestResponse(cookie)
c := &kocha.Context{Request: req, Response: res}
err = m.Process(app, c, func() error {
actual := c.Session
expected := make(kocha.Session)
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Session
expect = make(kocha.Session)
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
}()
func() {
app := kocha.NewTestApp()
store := kocha.NewTestSessionCookieStore()
m := newTestSessionMiddleware(store)
sess := make(kocha.Session)
sess[m.ExpiresKey] = "1383820443"
sess["brown fox"] = "lazy dog"
value, err := store.Save(sess)
if err != nil {
t.Fatal(err)
}
cookie := &http.Cookie{
Name: m.Name,
Value: value,
}
req, res := newRequestResponse(cookie)
c := &kocha.Context{Request: req, Response: res}
err = m.Process(app, c, func() error {
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddlware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Session
expect = kocha.Session{
m.ExpiresKey: "1383820443",
"brown fox": "lazy dog",
}
if !reflect.DeepEqual(actual, expect) {
t.Errorf("Expect %v, but %v", expect, actual)
}
}()
}
func TestSessionMiddleware_After(t *testing.T) {
app := kocha.NewTestApp()
origNow := util.Now
util.Now = func() time.Time { return time.Unix(1383820443, 0) }
defer func() {
util.Now = origNow
}()
r, err := http.NewRequest("GET", "/", nil)
if err != nil {
t.Fatal(err)
}
w := httptest.NewRecorder()
req, res := &kocha.Request{Request: r}, &kocha.Response{ResponseWriter: w}
c := &kocha.Context{Request: req, Response: res}
c.Session = make(kocha.Session)
m := &kocha.SessionMiddleware{Store: &NullSessionStore{}}
m.SessionExpires = time.Duration(1) * time.Second
m.CookieExpires = time.Duration(2) * time.Second
if err := m.Process(app, c, func() error {
return nil
}); err != nil {
t.Error(err)
}
var (
actual interface{} = c.Session
expected interface{} = kocha.Session{
m.ExpiresKey: "1383820444", // + time.Duration(1) * time.Second
}
)
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
c.Session[m.ExpiresKey] = "1383820444"
value, err := m.Store.Save(c.Session)
if err != nil {
t.Fatal(err)
}
c1 := res.Cookies()[0]
c2 := &http.Cookie{
Name: m.Name,
Value: value,
Path: "/",
Expires: util.Now().UTC().Add(m.CookieExpires),
MaxAge: 2,
Secure: false,
HttpOnly: m.HttpOnly,
}
actual = c1.Name
expected = c2.Name
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual, err = m.Store.Load(c1.Value)
if err != nil {
t.Error(err)
}
expected, err = m.Store.Load(c2.Value)
if err != nil {
t.Error(err)
}
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual = c1.Path
expected = c2.Path
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual = c1.Expires
expected = c2.Expires
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual = c1.MaxAge
expected = c2.MaxAge
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual = c1.Secure
expected = c2.Secure
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
actual = c1.HttpOnly
expected = c2.HttpOnly
if !reflect.DeepEqual(actual, expected) {
t.Errorf("Expect %v, but %v", expected, actual)
}
}
type ValidateTestSessionStore struct{ validated bool }
func (s *ValidateTestSessionStore) Save(sess kocha.Session) (string, error) { return "", nil }
func (s *ValidateTestSessionStore) Load(key string) (kocha.Session, error) { return nil, nil }
func (s *ValidateTestSessionStore) Validate() error {
s.validated = true
return fmt.Errorf("session store validate error")
}
type NullSessionStore struct{}
func (s *NullSessionStore) Save(sess kocha.Session) (string, error) {
return "", nil
}
func (s *NullSessionStore) Load(key string) (kocha.Session, error) {
return nil, nil
}
func (s *NullSessionStore) Validate() error {
return nil
}
func TestSessionMiddleware_Validate(t *testing.T) {
for _, v := range []struct {
m *kocha.SessionMiddleware
expect interface{}
}{
{(*kocha.SessionMiddleware)(nil), fmt.Errorf("kocha: session: middleware is nil")},
{&kocha.SessionMiddleware{}, fmt.Errorf("kocha: session: because Store is nil, session cannot be used")},
{&kocha.SessionMiddleware{
Store: &ValidateTestSessionStore{},
}, fmt.Errorf("kocha: session: Name must be specified")},
{&kocha.SessionMiddleware{Name: "test_session"}, fmt.Errorf("kocha: session: because Store is nil, session cannot be used")},
{&kocha.SessionMiddleware{
Name: "test_session",
Store: &ValidateTestSessionStore{},
}, fmt.Errorf("session store validate error")},
{&kocha.SessionMiddleware{
Name: "test_session",
Store: &NullSessionStore{},
}, nil},
} {
actual := v.m.Validate()
expect := v.expect
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Validate() with %#v => %#v; want %#v`, v.m, actual, expect)
}
}
for _, v := range []struct {
m *kocha.SessionMiddleware
expect string
}{
{&kocha.SessionMiddleware{}, "_kocha._sess._expires"},
{&kocha.SessionMiddleware{ExpiresKey: "test.expires.key"}, "test.expires.key"},
} {
v.m.Name = "test_session"
v.m.Store = &NullSessionStore{}
if err := v.m.Validate(); err != nil {
t.Error(err)
}
actual := v.m.ExpiresKey
expect := v.expect
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.SessionMiddleware.Validate(); ExpiresKey => %#v; want %#v`, actual, expect)
}
}
}
func TestFlashMiddleware_Before_withNilSession(t *testing.T) {
app := kocha.NewTestApp()
m := &kocha.FlashMiddleware{}
c := &kocha.Context{Session: nil}
err := m.Process(app, c, func() error {
actual := c.Flash
expect := kocha.Flash(nil)
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`FlashMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
return fmt.Errorf("expected error")
})
var actual interface{} = err
var expect interface{} = fmt.Errorf("expected error")
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`kocha.FlashMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
actual = c.Flash
expect = kocha.Flash(nil)
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`FlashMiddleware.Process(app, c, func) => %#v; want %#v`, actual, expect)
}
}
func TestFlashMiddleware(t *testing.T) {
app := kocha.NewTestApp()
m := &kocha.FlashMiddleware{}
c := &kocha.Context{Session: make(kocha.Session)}
if err := m.Process(app, c, func() error {
actual := c.Flash.Len()
expect := 0
if !reflect.DeepEqual(actual, expect) {
t.Errorf(`FlashMiddleware.Process(app, c, func); c.Flash.Len() => %#v; want %#v`, actual, expect)
}
c.Flash.Set("test_param", "abc")
return nil
}); err != nil {
t.Error(err)
}
c.Flash = nil
if err := m.Process(app, c, func() error {
var actual interface{} = c.Flash.Len()
var expected interface{} = 1
if !reflect.DeepEqual(actual, expected) {
t.Errorf(`FlashMiddleware.Process(app, c, func) then Process(app, c, func); c.Flash.Len() => %#v; want %#v`, actual, expected)
}
actual = c.Flash.Get("test_param")
expected = "abc"
if !reflect.DeepEqual(actual, expected) {
t.Errorf(`FlashMiddleware.Process(app, c, func) then Process(app, c, func); c.Flash.Get("test_param") => %#v; want %#v`, actual, expected)
}
return nil
}); err != nil {
t.Error(err)
}
c.Flash = nil
if err := m.Process(app, c, func() error {
var actual interface{} = c.Flash.Len()
var expected interface{} = 0
if !reflect.DeepEqual(actual, expected) {
t.Errorf(`FlashMiddleware.Process(app, c, func) then Process(app, c, func); emulated redirect; c.Flash.Len() => %#v; want %#v`, actual, expected)
}
actual = c.Flash.Get("test_param")
expected = ""
if !reflect.DeepEqual(actual, expected) {
t.Errorf(`FlashMiddleware.Process(app, c, func) then Process(app, c, func); emulated redirect; c.Flash.Get("test_param") => %#v; want %#v`, actual, expected)
}
return nil
}); err != nil {
t.Error(err)
}
}