Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int to long #264

Merged
merged 5 commits into from
Jan 26, 2017
Merged

Int to long #264

merged 5 commits into from
Jan 26, 2017

Conversation

mozts2005
Copy link
Member

Changed all public properties to from int to long per docs
https://developer.zendesk.com/rest_api/docs/core/introduction#id-integers
fixed #263, fixed #262

@mozts2005 mozts2005 added this to the 3.6 milestone Jan 26, 2017
@mozts2005
Copy link
Member Author

@AppVeyorBot
Copy link

1 similar comment
@mozts2005
Copy link
Member Author

@mozts2005 mozts2005 merged commit 620e374 into master Jan 26, 2017
@bvillanueva-mdsol
Copy link

@mozts2005 Thank you so much for addressing this. We are currently using your library. We really appreciate the work your team is doing. Will this PR be released in a nuget very soon?

  • Brent

@mozts2005
Copy link
Member Author

@bvillanueva-mdsol I think we can release this. I was hoping to get feedback that the changes didn't create more issues.

@bvillanueva-mdsol
Copy link

@mozts2005 Thanks for the info. We can help in testing. We can test the Zendesk ticket and articles part of the client. :)

@mozts2005
Copy link
Member Author

@bvillanueva-mdsol Has been released to nuget.

@bvillanueva-mdsol
Copy link

Thanks @mozts2005 For the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreatePost() Exception Need to change sectionid from int to long in article results
3 participants