updated HelpCenterApi to properly format URL like Core does #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test for URI format
|
It looks like a few test are now failing. Please have a look at them |
|
They were failing when I checked out the project, as far as I could tell. I ran them first thing. I will investigate. |
|
Taking a different approach with some other changes. Will open a new one later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test for URI format
I had used core first (thank you, btw!) and it took me a few minutes to track down why the HelpCenter API was not formatting the URL in a similar fashion. This should remedy that problem.
This is my first PR, so please let me know if you need anything from me or want any additional information.