Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortOrder is ignored for search results #238

Closed
mbtyomkin opened this issue Sep 2, 2016 · 1 comment
Closed

SortOrder is ignored for search results #238

mbtyomkin opened this issue Sep 2, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@mbtyomkin
Copy link

Trying to use Search.SearchFor and passing "asc" as SortOrder (default on zendesk is desc - https://developer.zendesk.com/rest_api/docs/core/search), but the code seems to pass "desc" or nothing to the API. I assume that's because the default was "asc" before. Recommendation: do not assume the default and pass along the user's value. Perhaps introduce an enum for this value, so the user does not pass an invalid value (ex. "ascending").

@mozts2005
Copy link
Member

@mbtyomkin Please test this change to make sure I fixed your issue. You will need to use the myget feed for the pre-release version.

@mozts2005 mozts2005 reopened this Sep 16, 2016
@mozts2005 mozts2005 self-assigned this Sep 16, 2016
@mozts2005 mozts2005 added this to the 3.5.1 milestone Sep 16, 2016
@mozts2005 mozts2005 added the Bug label Sep 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants