Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize type projection when checking Pointee trait #752

Open
celinval opened this issue Jan 13, 2022 · 0 comments
Open

Normalize type projection when checking Pointee trait #752

celinval opened this issue Jan 13, 2022 · 0 comments
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.

Comments

@celinval
Copy link
Contributor

The compiler has added an argument to the method ptr_metadata_ty to normalize the struct tail type when checking the Pointee trait. This is the change that added this option: rust-lang/rust@5a1c460

We haven't added the normalization on RMC yet. You can see potential issues here: rust-lang/rust#92128 and rust-lang/rust#92577.

We might be able to use similar logic to this code to get all the necessary information to do the normalization: https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/compiler/rustc_traits/src/normalize_projection_ty.rs
@celinval celinval added the [C] Bug This is a bug. Something isn't working. label Jan 13, 2022
@zhassan-aws zhassan-aws added MLP - Must Have and removed [C] Bug This is a bug. Something isn't working. MLP - Must Have labels Mar 16, 2022
@YoshikiTakashima YoshikiTakashima mentioned this issue Jun 15, 2022
Closed
@tedinski tedinski added the [C] Internal Tracks some internal work. I.e.: Users should not be affected. label Nov 14, 2022
@celinval celinval removed their assignment Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tedinski @celinval @zhassan-aws