Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop version showing on safari mobile #631

Closed
sordespilosus opened this issue Apr 3, 2017 · 9 comments
Closed

Desktop version showing on safari mobile #631

sordespilosus opened this issue Apr 3, 2017 · 9 comments
Milestone

Comments

@sordespilosus
Copy link

Hi all

I create issue, as well Nikolas asked me.

So, I download node.js, install it, install al packages, install plugin for Sublime, edit PATH. Its work ok, mjml file was create, and compiletd markup was output in html file.

Next, i get mjml code from you live preview (https://mjml.io/try-it-live/ryQglRCng), and paste in my mjml file, and do output in html. Open result on mobile device, and result page is not adaptive:

s70403-175003

Page just scaling to fit on my mobile device.

But in your live preview page look like that:

screenshot-mjml io 2017-04-03 17-52-46

What i do wrong? Why same code in your preview adaptive, but in my page is not?

Thank you for help and sorry for my english. I never learn it before.

@fusion27
Copy link

fusion27 commented Apr 3, 2017

@sordespilosus let's see your MJML

@iRyusa iRyusa changed the title help for newbie Desktop version showing on safari mobile Apr 3, 2017
@iRyusa
Copy link
Member

iRyusa commented Apr 3, 2017

Hi @sordespilosus !

Thanks for reporting this, it looks to be solved when adding a meta viewport

<meta name="viewport" content="width=device-width, initial-scale=1.0">

We'll see if it break something on any clients/device to add this

@sordespilosus
Copy link
Author

@iRyusa, yes, is it! Thanks!

i thought this meta added automatically, and dont cheked compiled html attentively )

now i continue research this))

@sordespilosus
Copy link
Author

@iRyusa, if i manually paste meta name="viewport" in compiled html, and edited mjml source-file, framework delete this string in html after output. How can i fix, or patched this?

Thanks!

@iRyusa
Copy link
Member

iRyusa commented Apr 4, 2017

You can dirty patch it in the node_modules/mjml-core/lib/configs/defaultContainer.js and add the meta viewport.

@sordespilosus
Copy link
Author

sordespilosus commented Apr 4, 2017

@iRyusa thanks!

Its release bug, or i install/configure something wrong?

@iRyusa
Copy link
Member

iRyusa commented Apr 4, 2017

It's a bug in current MJML version, should be fix in 3.3.1 👍

@sordespilosus
Copy link
Author

@iRyusa, thanks! I'll be wait 3.3.1 release)

@ngarnier ngarnier added this to the 3.3.1 milestone Apr 7, 2017
@ngarnier
Copy link
Member

Hello,

Thanks for reporting @sordespilosus, it's now fixed (npm install mjml to update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants