Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<mj-raw> in <mj-head> doesn't work (content of mj-raw doesn't appear in rendered <head>) #1338

Closed
tkafka opened this issue Sep 3, 2018 · 5 comments
Closed

<mj-raw> in <mj-head> doesn't work (content of mj-raw doesn't appear in rendered <head>) #1338

tkafka opened this issue Sep 3, 2018 · 5 comments

Comments

@tkafka
Copy link

tkafka commented Sep 3, 2018 •
edited
Loading

Reproduction Steps:

I put a following block in <mj-head>, expecting the meta tag to appear in rendered html.

<!-- shis should work but it doesn't -->
<mj-raw>
	<meta name="format-detection" content="telephone=no, address=no, email=no, date=no" />
</mj-raw>

Expected behavior:

<meta> shows up in <head> section of rendered html.

Observed behavior:

<meta> tag is not there.

However, this hack works:

<!-- this hack works -->
<mj-style>
	</style>
	<meta name="format-detection" content="telephone=no, address=no, email=no, date=no" />
	<style>
</mj-style>

MJML version:

4.0.3
@tkafka tkafka changed the title mj-raw in mj-head doesn't work (content of mj-raw doesn't appear in rendered <head>) <mj-raw> in <mj-head> doesn't work (content of mj-raw doesn't appear in rendered <head>) Sep 3, 2018
@iRyusa
Copy link
Member

iRyusa commented Sep 3, 2018

Hi,
It's WIP addition for 4.2.X see #82 (some of tickets of 4.2 has been closed but not pushed yet, a beta should be released this week)

@iRyusa iRyusa closed this as completed Sep 3, 2018
@tkafka
Copy link
Author

tkafka commented Sep 3, 2018

Thanks! Looking forward to 4.2!

@donni106
Copy link

donni106 commented Jan 7, 2019

This seems to not work in 4.3.
I still need the hack from @tkafka.

@donni106 donni106 mentioned this issue Jan 7, 2019
Closed
@tkafka
Copy link
Author

tkafka commented Jan 7, 2019

@donni106 That would be a regression then - I can confirm this works (writes a meta tag into html header) in 4.2.0:

<mj-head>
<mj-raw>
	<meta name="format-detection" content="telephone=no, address=no, email=no, date=no" />
</mj-raw>
...
</mj-head>

Just an idea - did you check if you call this inside mj-head?

@ngarnier
Copy link
Member

ngarnier commented Jan 7, 2019

No regression, more likely a version conflict on @donni106 side. Let's keep the conversation in #82 (comment) to avoid spreading it across multiple issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@iRyusa @tkafka @donni106 @ngarnier