-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please re-include msdia140typelib_clr0200.dll in the NuGet package Microsoft.TestPlatform.17.4.x #3922
Comments
cc @MarcoRossignoli and @nohwnd |
@arvindshmicrosoft Would you mind sharing with us the scenario in which you are using it? Ideally if you have a repro that would be awesome. Is it that you were relying on the fact this dll was shipped with test platform? We removed this dependency because it's not used anywhere in our code. EDIT: The old dll was actually deprecated but we are shipping the new one that is recommended and called |
Thanks @Evangelink for sharing the reason behind this change. Let me share the scenario behind this issue:
I can work around by now proceeding to run Though - I totally understand and respect if you stay with the change and do not choose to include |
@arvindshmicrosoft Thanks for the context, we are not going to ship that library anymore, because it was made to support .NET Framework 2.0 and we don't have any use for it anymore because we replaced it with p/Invoke. I've added you to the original thread that explains the details and motivated the removal of this library, hopefully there is alternative library already shipped with VS. Or you can add additional nuget to their build pipeline to create and ship it for you. I admittedly don't know enough about how this works. From what I understand we moved to using PInvoke with msdia140, to consume it from our C# code. Is not generating a typelib for it, and using that a lost opportunity for us? |
@nohwnd - the explanations on this Issue are clear and I will close this issue. I understand why the typelib was removed from VSTest. We will generate the typelib using MIDL and tlbimp for now. Hopefully in the future we will have some other cleaner way for MSDIA interop for all. |
Suggestion from @MarcoRossignoli: depending on your needs, you could update your code to rely on https://github.com/dotnet/symreader-portable. |
Thank you @Evangelink - unfortunately my requirement is solely for native PDBs, so DIA is the only way out. |
Just in case this could help, according to their readme:
|
Description
Microsoft.TestPlatform.17.4.0-preview-20220707-01 is missing msdia140typelib_clr0200.dll. In past releases of this NuGet (the latest prior one I can see is 17.3.0-preview-20220612-01), this typelib is present in tools/net451/Common7/IDE/Extensions/TestPlatform/msdia140typelib_clr0200.dll.
Please bring back the msdia140typelib_clr0200.dll as it breaks existing app and test code which uses the DIA SDK from C# and needs this typelib.
Steps to reproduce
N/A
Expected behavior
The Microsoft.TestPlatform will include msdia140typelib_clr0200.dll under tools/net451/Common7/IDE/Extensions/TestPlatform/msdia140typelib_clr0200.dll
Actual behavior
Microsoft.TestPlatform.17.4.0-preview-20220707-01 is missing msdia140typelib_clr0200.dll.
Diagnostic logs
N/A
Environment
N/A
The text was updated successfully, but these errors were encountered: