Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old image version is not shown when viewing a pull request change for an image #2914

Closed
Artur- opened this issue Aug 18, 2021 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Artur-
Copy link

Artur- commented Aug 18, 2021

  • Extension version: v0.29.2
  • VSCode Version: 1.59.0
  • OS: GitHub editor

Steps to Reproduce:

  1. Open https://github.dev/Artur-/screenshot-public/pull/1
  2. Click "image.png"

Expected outcome:
The image currently in the repository is shown on the left side, the image included in the PR is shown on the right side

Actual outcome:
The left side always shows "An error occurred while loading the image". The right side correctly shows the image in the PR

@Artur- Artur- changed the title Old images is not shown when viewing a pull request change for an image Old image is not shown when viewing a pull request change for an image Aug 18, 2021
@Artur- Artur- changed the title Old image is not shown when viewing a pull request change for an image Old image version is not shown when viewing a pull request change for an image Aug 18, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 18, 2021

Thanks for filing this! Looks like it's an upstream issue: microsoft/vscode#131079

@alexr00 alexr00 closed this as completed Aug 18, 2021
@alexr00 alexr00 reopened this Aug 20, 2021
@alexr00 alexr00 self-assigned this Aug 20, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Aug 20, 2021
@alexr00 alexr00 added this to the August 2021 milestone Aug 20, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 20, 2021

The VS Code regression is not going to be fixed anytime soon. I have added a temporary storage for images that gets wiped on extension activation which improves the situation for now: #2925

@alexr00 alexr00 closed this as completed Aug 20, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 26, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Aug 26, 2021

Using the repro steps above, I still get an error message on the left side.

Extension version v2021.8.36609

@rzhao271 rzhao271 reopened this Aug 26, 2021
@rzhao271 rzhao271 added verification-found Issue verification failed and removed verified Verification succeeded labels Aug 26, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 27, 2021

Looks like there's an issue with this when used with the Remote Repositories extension (as is the case with github.dev).

Verifier, please verify using desktop VS Code with a local repository (not using Remote Repositories). I will follow up with a bug with Remote Repositories.

@alexr00 alexr00 closed this as completed Aug 27, 2021
@alexr00 alexr00 removed the verification-found Issue verification failed label Aug 27, 2021
@connor4312 connor4312 added the verified Verification succeeded label Aug 27, 2021
@connor4312
Copy link
Member

This works if the PR is checked out. If it isn't checked out and you click on the image from the Pull Requests view, this error happens:

image

If this is "as designed" this can be marked as verified for now though

@connor4312 connor4312 reopened this Aug 27, 2021
@connor4312 connor4312 removed the verified Verification succeeded label Aug 27, 2021
@alexr00
Copy link
Member

alexr00 commented Aug 30, 2021

That is as-designed for now. Thanks for verifying!

@alexr00 alexr00 added the verified Verification succeeded label Aug 30, 2021
@alexr00 alexr00 closed this as completed Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants