-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Old image version is not shown when viewing a pull request change for an image #2914
Comments
Thanks for filing this! Looks like it's an upstream issue: microsoft/vscode#131079 |
The VS Code regression is not going to be fixed anytime soon. I have added a temporary storage for images that gets wiped on extension activation which improves the situation for now: #2925 |
Using the repro steps above, I still get an error message on the left side. Extension version v2021.8.36609 |
Looks like there's an issue with this when used with the Remote Repositories extension (as is the case with github.dev). Verifier, please verify using desktop VS Code with a local repository (not using Remote Repositories). I will follow up with a bug with Remote Repositories. |
That is as-designed for now. Thanks for verifying! |
Steps to Reproduce:
Expected outcome:
The image currently in the repository is shown on the left side, the image included in the PR is shown on the right side
Actual outcome:
The left side always shows "An error occurred while loading the image". The right side correctly shows the image in the PR
The text was updated successfully, but these errors were encountered: