Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual bell style should optionally affect the entire terminal pane #8889

Closed
lzybkr opened this issue Jan 26, 2021 · 7 comments
Closed

Visual bell style should optionally affect the entire terminal pane #8889

lzybkr opened this issue Jan 26, 2021 · 7 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.

Comments

@lzybkr
Copy link
Member

lzybkr commented Jan 26, 2021

In 1.6 - the visual bellStyle briefly displays a bell in the tab. I find this too subtle and easy to miss, especially when one's eyes are looking at the bottom of the terminal.

I'd originally envisioned a visible bell as briefly inverting the terminal - that would be hard to miss.

After experimenting with the shaders (and there is even a shader for inverting) - I think the visual bell feedback should be a customizable shader. Invert or even Retro could be good defaults, but I'm sure someone will come up with a really nice shader for a nice full window visual feedback effect.

@lzybkr lzybkr added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 26, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 26, 2021
@skyline75489
Copy link
Collaborator

Are you expecting something that Git bash does in #8737 ? The "Visual Bell" effect?

@lzybkr
Copy link
Member Author

lzybkr commented Jan 26, 2021

I didn't realize there was an escape sequence for that and that it is now supported. That is certainly a reasonable choice, but that could be jarring too, which is why I suggested a configurable shader.

I do like the idea of applications just sending BEL and the terminal deciding how to notify the user rather than each tool needing configuration option to choose visual versus audible.

@DHowett
Copy link
Member

DHowett commented Jan 28, 2021

I tend to agree. We can add more visual cues to the visual bell style.

@DHowett DHowett added this to the Terminal Backlog milestone Jan 28, 2021
@DHowett DHowett added Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 28, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 28, 2021
@DHowett DHowett changed the title Visual bell style should affect the entire terminal window Visual bell style should optionally affect the entire terminal pane Jan 28, 2021
@DHowett
Copy link
Member

DHowett commented Jan 28, 2021

Triaged into backlog. An enterprising youth could come along and add a cool visual effect if they wanted. 😄

@garyo

This comment has been minimized.

@zadjii-msft

This comment has been minimized.

@zadjii-msft
Copy link
Member

You know, we did this in #9270

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants