Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept! Redesign the tab page control/title bar merged with the tab page #5908

Open
Shomnipotence opened this issue Sep 18, 2021 · 6 comments
Assignees
Labels
area-TabView feature proposal New feature proposal team-Controls Issue for the Controls team team-Design

Comments

@Shomnipotence
Copy link

Shomnipotence commented Sep 18, 2021

[Concept! Redesign the tab control/tab bar in the Title bar]

Use separate cards to update the tab bar design

Concept

WindowsTerminal3 拷贝2

Rationale

  • Existing tab page design
    image
    image
    image
    This is the existing tab page design. Its basic concept is that assuming the title bar and window are the base layer, the tab page is one level above it. This requires at least two levels. In addition, what’s worse is that it performs worse on applications such as Windows Terminal, because there is no toolbar below the tabs, so it looks out of sync with the bottom.

  • Should the tabs be made transparent(App Acrylic)?
    This is a good idea, but it requires a lot of extra work and many different situations. Use a fixed color or Mica material for the title bar? Does Tab use in-app acrylic? Is there a toolbar below? Tab’s in-app acrylic uses content background or title bar background?
    It's too complicated, it doesn't make sense.

  • This is why we should use this style of tab page. It is suitable for all backgrounds-whether it is mica material, in-app acrylic, background acrylic, any background, browser (with toolbar), Windows terminal (without toolbar)...

More Image

WindowsTerminal3 拷贝2

Image Background
WindowsTerminal3 拷贝

Windows 10 Style
WindowsTerminal3
WindowsTerminal4

@Shomnipotence Shomnipotence added the feature proposal New feature proposal label Sep 18, 2021
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 18, 2021
@Shomnipotence Shomnipotence changed the title Proposal:Concept! Redesign the tab page control/title bar merged with the tab page Concept! Redesign the tab page control/title bar merged with the tab page Sep 18, 2021
@StephenLPeters StephenLPeters removed the needs-triage Issue needs to be triaged by the area owners label Sep 23, 2021
@jaigak
Copy link
Contributor

jaigak commented Sep 24, 2021

Don't use the same background for the tab view and the main content area. Makes it harder to distinguish.

@vsnthdev
Copy link

vsnthdev commented Oct 1, 2021

That terminal looks 😍

@m1karii
Copy link

m1karii commented Nov 11, 2021

I really like this design. It 'd be really nice to have this when v2.0 drops.

@LasseRosenow
Copy link

grafik

microsoft edge canary seems to be moving in this direction 😍

@Stanzilla
Copy link

Stanzilla commented Apr 29, 2022

I think this is kinda backwards, in my mind the non active tabs should be dimmer and the active one lighter and the reverse in dark mode?

@LasseRosenow
Copy link

LasseRosenow commented Apr 29, 2022

I think this is kinda backwards, in my mind the non active tabs should be dimmer and the active one lighter and the reverse in dark mode?

No it makes much more sense for the active ones to be lighter in dark mode as well. Just as it always has been in edge and every other UI framework.

Because also in dark mode the general conception is to highlight active elements by brightening them up. Not darkening them.

Windows terminal/winui always was considered to be really weird with their approach of having the active tab to be black on dark mode.
I think this originated from the concept that they wanted the tab to have the same background color as the rest of the terminal, which ultimately didn't work If people enabled blur or changed the background color a bit, what many did.

But this issue was more about the shape of the tabs tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView feature proposal New feature proposal team-Controls Issue for the Controls team team-Design
Projects
None yet
Development

No branches or pull requests

8 participants