-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate whether EventTarget should be constructable #23
Comments
@mhegazy would removing the constructor affect the |
As a type query, or a As a type query on something of type If using a So either way, there should be no difference. |
i believe @zhengbli meant |
@DanielRosenwasser @mhegazy sorry I meant |
It would be sufficient to only remove the constructor (not the whole declared var). |
the constructor does exist at runtime too, it is just illigal to call. This is the same for almost all DOM classes. i think the right fix here is to switch all DOM declarations to classes, and make thier constructors private. this requires microsoft/TypeScript#2341 |
As this issue belongs to a larger parent issue, I'm closing this one. |
It seems like it will always throw an error, so perhaps we shouldn't mark it as constructable.
The text was updated successfully, but these errors were encountered: