Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise XmlResponseInvalidError when using NodeRelations #117

Closed
FisherTsai opened this issue Nov 17, 2021 · 1 comment · Fixed by #121
Closed

Don't raise XmlResponseInvalidError when using NodeRelations #117

FisherTsai opened this issue Nov 17, 2021 · 1 comment · Fixed by #121

Comments

@FisherTsai
Copy link

Function NodeRelations raises XmlResponseInvalidError when the target element isn't used in any relations. In this situation, OSM API do return an valid XML with an empty <osm> element (Check the definition here). I don't think raising XmlResponseInvalidError in this situation is a proper way to go. It might be better to return an empty list, just like the behavior in osmapi v1.0.0.

Consider to make a change for this? For this function, improving the error handling to deal with this or just rolling back to v1.0.0?

Notes that function NodeWays has the same issue.

@metaodi
Copy link
Owner

metaodi commented Nov 20, 2021

@FisherTsai thanks for reporting this issue. I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants