enhance(dev-dashboard): reuse Paginator molecule in flaws and translation dashboards #9319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
changed the title
github-actions
bot
added
the
merge conflicts 🚧
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
|
@queengooborg PTAL at the failing tests. 🙂 |
|
All fixed! Looks like an unused variable was removed and then a recent change started using it -- a simple diff revert did the trick! |
caugner
approved these changes
Apr 4, 2024
caugner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon noticing that the translation differences dashboard used a different paginator than the flaws dashboard, I decided that it would make a lot more sense to use the same pagination everywhere. I found that we already had a
Paginatemolecule in place, which provides exactly what we're looking for already.This PR updates both the flaws dashboard and translation differences dashboard to use the existing
Paginatemolecule instead of implementing its own logic, pulling over features as needed. This also performs a few other tweaks to synchronize the appearance of both dashboards more.Note: the dashboard for missing translations is actually broken on my end. As such, I have not been able to test that particular page.