Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable exceptions flag for wasm #782

Merged
merged 1 commit into from
May 10, 2022
Merged

enable exceptions flag for wasm #782

merged 1 commit into from
May 10, 2022

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented May 9, 2022 •
edited by caugner
Loading

Fixes #781.

@fiji-flo fiji-flo requested a review from schalkneethling May 9, 2022 15:22
@fiji-flo
Copy link
Contributor Author

fiji-flo commented May 9, 2022

This should fix: https://github.com/mdn/interactive-examples/issues/2106

I haven't run this locally yet. Maybe someone beats me to it.

@fiji-flo
Copy link
Contributor Author

@schalkneethling this works. Could you see that Hamish can use it?

@schalkneethling
Copy link

This LGTM, thanks @fiji-flo - @hamishwillee is this what you needed? Thanks!

@hamishwillee
Copy link

hamishwillee commented May 10, 2022 •
edited
Loading

@schalkneethling Probably - certainly its a supported feature: https://github.com/WebAssembly/wabt/blob/main/src/wabt.post.js#L19
But the only way to know for sure would be to write an example that uses exceptions. I don't plan on doing that for a little while (its on the queue). I don't think it would do any harm to merge this though.

@hamishwillee
Copy link

PS Thanks @fiji-flo !

@schalkneethling
Copy link

Thank you, @hamishwillee and @fiji-flo! Merging.

@schalkneethling schalkneethling self-assigned this May 10, 2022
@schalkneethling schalkneethling added the enhancement Improves an existing feature. label May 10, 2022
@schalkneethling schalkneethling merged commit 59da034 into main May 10, 2022
@schalkneethling schalkneethling deleted the enable-wasm-exceptions branch May 10, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schalkneethling schalkneethling Awaiting requested review from schalkneethling

Assignees

@schalkneethling schalkneethling

Labels
enhancement Improves an existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable WebAssemblyExceptions
3 participants
@fiji-flo @schalkneethling @hamishwillee