Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Martin server heartbeat for monitoring the service health #168

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

yamaszone
Copy link
Contributor

@yamaszone yamaszone commented Jan 14, 2021

Detect Martin server heartbeat for monitoring the service health:

  • Simply returns HTTP 200 OK

NOTE: we have deployed Martin via Kubernetes. This PR helps to do a lightweight ping by both Kubelet as well as load balancer probes to detect the service health before auto-restart on failure or sending traffic. This is also used by monitors to alert on unexpected failures.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #168 (f1800dd) into master (e221fd3) will increase coverage by 0.02%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   56.70%   56.73%   +0.02%     
==========================================
  Files          13       13              
  Lines         626      631       +5     
==========================================
+ Hits          355      358       +3     
- Misses        271      273       +2     
Impacted Files Coverage Δ
src/server.rs 72.02% <60.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e221fd3...f1800dd. Read the comment docs.

Copy link
Collaborator

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepankuzmin stepankuzmin merged commit fce1a9e into maplibre:master Jan 16, 2021
@stepankuzmin
Copy link
Collaborator

Hey @yamaszone

Thanks for the PR, merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants