Skip to content

Commit

Permalink
changed engine.broadphase to engine.grid
Browse files Browse the repository at this point in the history
  • Loading branch information
liabru committed Mar 21, 2021
1 parent 1aa8ed0 commit b74e400
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 41 deletions.
3 changes: 0 additions & 3 deletions src/collision/Grid.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ var Grid = {};
module.exports = Grid;

var Pair = require('./Pair');
var Detector = require('./Detector');
var Common = require('../core/Common');

(function() {
Expand All @@ -22,8 +21,6 @@ var Common = require('../core/Common');
*/
Grid.create = function(options) {
var defaults = {
controller: Grid,
detector: Detector.collisions,
buckets: {},
pairs: {},
pairsList: [],
Expand Down
60 changes: 25 additions & 35 deletions src/core/Engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = Engine;
var World = require('../body/World');
var Sleeping = require('./Sleeping');
var Resolver = require('../collision/Resolver');
var Detector = require('../collision/Detector');
var Pairs = require('../collision/Pairs');
var Grid = require('../collision/Grid');
var Events = require('./Events');
Expand All @@ -35,29 +36,30 @@ var Body = require('../body/Body');
*/
Engine.create = function(options) {
options = options || {};

var defaults = {
positionIterations: 6,
velocityIterations: 4,
constraintIterations: 2,
enableSleeping: false,
events: [],
plugin: {},
grid: null,
timing: {
timestamp: 0,
timeScale: 1
},
broadphase: {
controller: Grid
}
metrics: {}
};

var engine = Common.extend(defaults, options);

engine.world = options.world || World.create(engine.world);
engine.pairs = Pairs.create();
engine.broadphase = engine.broadphase.controller.create(engine.broadphase);
engine.grid = Grid.create(engine.grid || engine.broadphase);

// temporary back compatibility
engine.broadphase = engine.grid;
engine.metrics = {};

return engine;
};
Expand All @@ -83,8 +85,8 @@ var Body = require('../body/Body');

var world = engine.world,
timing = engine.timing,
broadphase = engine.broadphase,
broadphasePairs = [],
grid = engine.grid,
gridPairs = [],
i;

// increment timestamp
Expand Down Expand Up @@ -119,26 +121,22 @@ var Body = require('../body/Body');
Constraint.postSolveAll(allBodies);

// broadphase pass: find potential collision pairs
if (broadphase.controller) {

// if world is dirty, we must flush the whole grid
if (world.isModified)
broadphase.controller.clear(broadphase);
Grid.clear(grid);

// update the grid buckets based on current bodies
broadphase.controller.update(broadphase, allBodies, engine, world.isModified);
broadphasePairs = broadphase.pairsList;
} else {
// if no broadphase set, we just pass all bodies
broadphasePairs = allBodies;
}
Grid.update(grid, allBodies, engine, world.isModified);
gridPairs = grid.pairsList;

// clear all composite modified flags
if (world.isModified) {
Composite.setModified(world, false, false, true);
}

// narrowphase pass: find actual collisions, then create or update collision pairs
var collisions = broadphase.detector(broadphasePairs, engine);
var collisions = Detector.collisions(gridPairs, engine);

// update collision pairs
var pairs = engine.pairs,
Expand Down Expand Up @@ -219,16 +217,12 @@ var Body = require('../body/Body');
* @param {engine} engine
*/
Engine.clear = function(engine) {
var world = engine.world;
var world = engine.world,
bodies = Composite.allBodies(world);

Pairs.clear(engine.pairs);

var broadphase = engine.broadphase;
if (broadphase.controller) {
var bodies = Composite.allBodies(world);
broadphase.controller.clear(broadphase);
broadphase.controller.update(broadphase, bodies, engine, true);
}
Grid.clear(engine.grid);
Grid.update(engine.grid, bodies, engine, true);
};

/**
Expand Down Expand Up @@ -427,21 +421,17 @@ var Body = require('../body/Body');
*/

/**
* An instance of a `Render` controller. The default value is a `Matter.Render` instance created by `Engine.create`.
* One may also develop a custom renderer module based on `Matter.Render` and pass an instance of it to `Engine.create` via `options.render`.
*
* A minimal custom renderer object must define at least three functions: `create`, `clear` and `world` (see `Matter.Render`).
* It is also possible to instead pass the _module_ reference via `options.render.controller` and `Engine.create` will instantiate one for you.
* A `Matter.Grid` instance.
*
* @property render
* @type render
* @deprecated see Demo.js for an example of creating a renderer
* @default a Matter.Render instance
* @property grid
* @type grid
* @default a Matter.Grid instance
*/

/**
* An instance of a broadphase controller. The default value is a `Matter.Grid` instance created by `Engine.create`.
* Replaced by and now alias for `engine.grid`.
*
* @deprecated use `engine.grid`
* @property broadphase
* @type grid
* @default a Matter.Grid instance
Expand Down
5 changes: 2 additions & 3 deletions src/render/Render.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ var Common = require('../core/Common');
var Composite = require('../body/Composite');
var Bounds = require('../geometry/Bounds');
var Events = require('../core/Events');
var Grid = require('../collision/Grid');
var Vector = require('../geometry/Vector');
var Mouse = require('../core/Mouse');

Expand Down Expand Up @@ -406,8 +405,8 @@ var Mouse = require('../core/Mouse');

Render.constraints(constraints, context);

if (options.showBroadphase && engine.broadphase.controller === Grid)
Render.grid(render, engine.broadphase, context);
if (options.showBroadphase)
Render.grid(render, engine.grid, context);

if (options.showDebug)
Render.debug(render, context);
Expand Down

0 comments on commit b74e400

Please sign in to comment.