Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make users aware of (new) validation results #37

Open
f1ames opened this issue Sep 1, 2023 · 2 comments
Open

Make users aware of (new) validation results #37

f1ames opened this issue Sep 1, 2023 · 2 comments
Labels
enhancement New feature or request external:sarif Requires changes in SARIF extension

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 1, 2023

As in title. Related to #6.

Currently there is no real visual cue when a validation has been performed - which makes it confusing... users have to figure out to open the SARIF viewer themselves - and if there are new validation errors due to a central policy update there won't be any CTA to handle/inspect those.

Not sure what we can do? Open the SARIF panel? (May require some changes in SARIF extension or a workaround because SARIF ext public API is quite minimalistic.) Show a popup notification? Doesn't VS-Code have some infrastructure for this? I'm seeing alerts/popups in the bottom right all the time..

Reported by @olensmar.

@f1ames f1ames added enhancement New feature or request external:sarif Requires changes in SARIF extension labels Sep 1, 2023
@olensmar olensmar changed the title Open SARIF/Validation panel when validation command is run Make users aware of (new) validation results Sep 1, 2023
@f1ames
Copy link
Contributor Author

f1ames commented Sep 4, 2023

My take on this would be that we want to notify users of new errors/warnings? So if validation runs and the number of errors remains the same maybe we shouldn't bother the user (assuming the he/she saw validation panel already - which should be true as it gets open on initial validation run).

So if subsequent validation runs yields different results, either we could reopen validation panel or show notification saying that there are new errors/warnings (with a button to open validation panel).

@olensmar
Copy link
Member

olensmar commented Sep 4, 2023

thanks @f1ames - a notification with an action to open the panel seems sufficient to me!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external:sarif Requires changes in SARIF extension
Projects
None yet
Development

No branches or pull requests

2 participants