Need to set environment to enable Estimators with TF <=1.3 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RunConfig (part of Estimator API) depends on the environment being set in TF_CONFIG to 'cloud'. If we don't set environment to 'cloud' then is_chief isn't enabled for the master and the TF program doesn't make progress. * TF 1.4 should be backwards compatible; i.e. it doesn't make use of environment in TF_CONFIG. So this code should be forward compatible. * Expand the unittest for replicas.go to cover the new code. * In replicas.go we should make a full DeepCopy of the PodTemplateSpec before modifying it. It turns out K8s provides auto-generated code to perform deep copies.
|
/test all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunConfig (part of Estimator API) depends on the environment being
set in TF_CONFIG to 'cloud'. If we don't set environment to 'cloud'
then is_chief isn't enabled for the master and the TF program doesn't
make progress.
TF 1.4 should be backwards compatible; i.e. it doesn't make use of
environment in TF_CONFIG. So this code should be forward compatible.
Expand the unittest for replicas.go to cover the new code.
In replicas.go we should make a full DeepCopy of the PodTemplateSpec
before modifying it. It turns out K8s provides auto-generated code to
perform deep copies.