Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: Send events when reveive invalid spec #623

Merged
merged 1 commit into from
Jun 5, 2018
Merged

pkg: Send events when reveive invalid spec #623

merged 1 commit into from
Jun 5, 2018

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Jun 4, 2018

Close #620

Signed-off-by: Ce Gao [email protected]


This change is Reviewable

@k8s-ci-robot k8s-ci-robot requested review from jimexist and mitake June 4, 2018 09:40
@gaocegege gaocegege changed the title pkg: Add event send statements pkg: Send events when reveive invalid spec Jun 4, 2018
@coveralls
Copy link

coveralls commented Jun 4, 2018

Coverage Status

Coverage remained the same at 57.214% when pulling cbf0156 on gaocegege:label into 93843ed on kubeflow:master.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ea770be into kubeflow:master Jun 5, 2018
yph152 pushed a commit to yph152/tf-operator that referenced this pull request Jun 18, 2018
jetmuffin pushed a commit to jetmuffin/tf-operator that referenced this pull request Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants