Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support CI using Travis. #14

Merged
merged 1 commit into from
Aug 5, 2017
Merged

Changes to support CI using Travis. #14

merged 1 commit into from
Aug 5, 2017

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Aug 5, 2017

No description provided.

@jlewi jlewi force-pushed the travis_test branch 2 times, most recently from 31712ae to 370003d Compare August 5, 2017 21:10
@jlewi jlewi changed the title Trivial change so we can check travis. Changes to support CI using Travis. Aug 5, 2017
@jlewi jlewi closed this Aug 5, 2017
@jlewi jlewi reopened this Aug 5, 2017
@jlewi
Copy link
Contributor Author

jlewi commented Aug 5, 2017

@wbuchwalter PTAL.

@wbuchwalter
Copy link
Contributor

Looks good to me!
This part of the README will need to be updated though as this won't work anymore with the new imports.

* Configure Travis to use glide to pull in dependencies.
* Override the default Travis test command to exclude tests in the Vendor
  directory.

* Renamed the mlkube imports to be github.com/jlewi/mlkube.io
  * I think this is needed because Travis will checkout the code as
   gopath/src/github.com/jlewi/mlkube.io
  * So changing the import is needed to make it work with Travis.
  * It also appears to be more consistent with gostyle and compatible with go deps.

* Add Travis widget to the README.

* Fix the readme and build scripts.
@jlewi jlewi merged commit fc893fe into master Aug 5, 2017
@jlewi jlewi deleted the travis_test branch August 5, 2017 22:54
Syulin7 added a commit to Syulin7/training-operator that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants