Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: webhook findContainer to avoid calling it in every patch function #2238

Open
ImpSy opened this issue Oct 10, 2024 · 4 comments · May be fixed by #2409
Open

Refactoring: webhook findContainer to avoid calling it in every patch function #2238

ImpSy opened this issue Oct 10, 2024 · 4 comments · May be fixed by #2409

Comments

@ImpSy
Copy link
Contributor

ImpSy commented Oct 10, 2024

Following a review in this PR #2232

We should modify the logic in webhook to avoid calling the findContainer function in every patch function, and make it more idomatic by returning a tuple (int, error)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions GitHub Actions
Copy link

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2025
@ImpSy
Copy link
Contributor Author

ImpSy commented Jan 28, 2025

/reopen

@google-oss-prow google-oss-prow bot reopened this Jan 28, 2025
@google-oss-prow Google OSS Prow
Copy link
Contributor

@ImpSy: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ImpSy ImpSy linked a pull request Jan 28, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor webhook patching logic spotinst/spark-on-k8s-operator
1 participant
@ImpSy