From 6a1531bc98cf467d69b27a9b386275b56695f3f4 Mon Sep 17 00:00:00 2001
From: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Date: Wed, 11 Nov 2020 11:21:48 +0000
Subject: [PATCH] Fix compare step for the early stopping (#1386)

---
 cmd/metricscollector/v1beta1/file-metricscollector/main.go | 4 ++--
 examples/v1beta1/early-stopping/median-stop.yaml           | 7 -------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/cmd/metricscollector/v1beta1/file-metricscollector/main.go b/cmd/metricscollector/v1beta1/file-metricscollector/main.go
index de4f308d608..f149899cfe8 100644
--- a/cmd/metricscollector/v1beta1/file-metricscollector/main.go
+++ b/cmd/metricscollector/v1beta1/file-metricscollector/main.go
@@ -228,9 +228,9 @@ func watchMetricsFile(mFile string, stopRules stopRulesFlag, filters []string) {
 
 					// Reduce steps if appropriate metric is reported.
 					// Once rest steps are empty we apply early stopping rule.
-					if restSteps, ok := metricStartStep[metricName]; ok {
+					if _, ok := metricStartStep[metricName]; ok {
 						metricStartStep[metricName]--
-						if restSteps != 0 {
+						if metricStartStep[metricName] != 0 {
 							continue
 						}
 					}
diff --git a/examples/v1beta1/early-stopping/median-stop.yaml b/examples/v1beta1/early-stopping/median-stop.yaml
index f6521d3bde7..0cef18e8cd1 100644
--- a/examples/v1beta1/early-stopping/median-stop.yaml
+++ b/examples/v1beta1/early-stopping/median-stop.yaml
@@ -21,13 +21,6 @@ spec:
         value: "3"
       - name: start_step
         value: "5"
-  metricsCollectorSpec:
-    collector:
-      kind: StdOut
-    source:
-      filter:
-        metricsFormat:
-          - ([\w|-]+)\s*=\s*((-?\d+)(\.\d+)?)
   parallelTrialCount: 2
   maxTrialCount: 15
   maxFailedTrialCount: 3