Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog: Add post on leveraging Katib for efficient RAG optimization. #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

varshaprasad96
Copy link

Closes: #160

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johnugeorge for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@varshaprasad96
Copy link
Author

cc: @franciscojavierarceo

Copy link
Contributor

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so great! One small nit: can you break up the text so that there are line breaks around every 80 characters or so? It'll help comment individual sections.

@franciscojavierarceo
Copy link
Contributor

franciscojavierarceo commented Feb 22, 2025

FYI @andreyvelich we can put this under GenAI page

@varshaprasad96
Copy link
Author

I'm not able to replicate the build error locally, trying to dig into it. Looks like I maybe missing some configuration, if someone has seen this issue before, that'd be super helpful.

@franciscojavierarceo
Copy link
Contributor

@tarekabouzeid did you encounter any issues here?

@tarekabouzeid
Copy link
Member

@tarekabouzeid did you encounter any issues here?

No, i haven't.
I used make server to start the pages locally, will try to compare the 2 branches and build this one.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great blog post @varshaprasad96!
I left a few comments.
/assign @varodrig @kubeflow/wg-training-leads @Electronic-Waste @helenxie-bit @akgraner
Please help us with the review

available in the [documentation][katib_api].

```yaml
apiVersion: "kubeflow.org/v1beta1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varshaprasad96 I am wondering whether SDK submission would be easier, since we don't need to explain how to build Docker image from your RAG pipeline?
https://www.kubeflow.org/docs/components/katib/getting-started/#getting-started-with-katib-python-sdk

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use PyTorch as base_image and install required packages as follows:

def tune(
  base_image="docker.io/pytorch/pytorch:2.2.1-cuda12.1-cudnn8-runtime",
  packages_to_install=["rag",....],
)

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great blog post!
LGTM form my PoV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create blogpost on optimising RAG Pipelines with Kubeflow Katib
5 participants