-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALIGNMENT TO REF LONGER THAN 2000bp #17
Comments
Hehe, I'm the one who should apologize for user issues. I highly appreciate the feedback! Ok, at least I will try to fix this bug. It is known, hence the message to stderr. It is nothing crucial (I believe), but obviously still desirable to fix. I may already have such a case in my data. I will look if I identify this in my data so that I can fix it. If not, I may come back to you about obtaining at least one of the read pairs that caused this. |
Happy to help! |
Hi @TDDB-limagrain, I have just released v0.7, which fixes this bug. The new release implements much more efficient multithreading impacting speed. I remember you did a comparison of runtime here. Not sure which version you tried, but at least compared to v0.6-0.6.1, the timing should be improved if you used several cores (the more cores the more the speedup). Happy for any feedback. |
Hi Kristoffer,
Thank you very much !
I’ve just compiled the v0.7 and started some mapping with; I am still really interested as a faster alternative to minimap2!
My plan is to then used it together with deepvariant to speed up the re-processing of large public resequencing data.
I’ll keep you in touch!
Best regards,
Thomas
De : Kristoffer ***@***.***>
Envoyé : vendredi 1 avril 2022 15:37
À : ksahlin/StrobeAlign ***@***.***>
Cc : DUGE DE BERNONVILLE, Thomas ***@***.***>; Mention ***@***.***>
Objet : Re: [ksahlin/StrobeAlign] ALIGNMENT TO REF LONGER THAN 2000bp (Issue #17)
Hi @TDDB-limagrain<https://github.com/TDDB-limagrain>,
I have just released v0.7, which fixes this bug. The new release implements much more efficient multithreading impacting speed. I remember you did a comparison of runtime here<#9 (comment)>. Not sure which version you tried, but at least compared to v0.6-0.6.1, the timing should be improved if you used several cores (the more cores the more the speedup). Happy for any feedback.
—
Reply to this email directly, view it on GitHub<#17 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXSO73QIFTH4RQVNTCBM3C3VC33ZLANCNFSM5PDYR2JA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Excellent! Yes, let me know how it goes and what your runtime and SV-calling experiments say. |
Hi @ksahlin, |
Cool B-) how many cores did you use? |
I used -t 4 ! |
Oh, yeah, I should have realized that from the command line in your other answer :) I'm positively surprised that it has this relatively "big" speedup only for 4 cores - its great though. The relative speedup will be even bigger with more cores. |
My job was submitted on the same node, so indeed there was a substantial improvement!
The output was piped to samtools command with 2 additional extra-cores in the same way.
I usually perform several alignments in parallel, that’s why I didn’t increase the number of threads.
Processors are: Intel(R) Xeon(R) CPU E5-2697 v4 @ 2.30GHz
If you are interested, I can make a test with 8, 16 and 32 cores for one sample
De : Kristoffer ***@***.***>
Envoyé : mardi 5 avril 2022 11:11
À : ksahlin/StrobeAlign ***@***.***>
Cc : DUGE DE BERNONVILLE, Thomas ***@***.***>; Mention ***@***.***>
Objet : Re: [ksahlin/StrobeAlign] ALIGNMENT TO REF LONGER THAN 2000bp (Issue #17)
Oh, yeah, I should have realized that from the command line in your other answer :)
I'm positively surprised that it has this relatively "big" speedup only for 4 cores - its great though. The relative speedup will be even bigger with more cores.
—
Reply to this email directly, view it on GitHub<#17 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXSO73SGPGRDFBWLP52JXJLVDP7T7ANCNFSM5PDYR2JA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks for the offer. It's not in priority, but if you have time/interested, sure! My biggest interest lies in that the variant calls are good. Next up on the schedule is to output supplementary alignments. |
Hi, I just launched some job using synthetic reads simulated with the rtg tools suite. That will be easier for me to share some results rather than using private resequencing runs. Will keep you in touch! |
hi @ksahlin ,
sorry for coming back with a new possible issue!
I used the very latest patch you've made to align a full sample against the public genome we discussed later.
The output was correctly piped to samtools for further duplicate marking and sorting, so thank you very much for allowing the redirection !
Everything goes well, but looking at the standard output, I obtained the following message several times:
ALIGNMENT TO REF LONGER THAN 2000bp - REPORT TO DEVELOPER.
For example:
ALIGNMENT TO REF LONGER THAN 2000bp - REPORT TO DEVELOPER. Happened for read: TGCCAATCCTGTGGGACGAATATGGGGCTCAAACCTCAGCCAAAACTCAATAGACACAGTGACGAATGTCTGGTAAAAAATTCAGACCAAAATACCAAAGGAGTAAGGCGTAGCAAGTCCCAGACCGAGAGTGAATAAAACCGGTTTTCCG ref len:53438756
Do you have any idea about such a behavior?
I ran strobealign with default parameters.
The text was updated successfully, but these errors were encountered: