New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a better message on missing song lyrics #1085

Closed

1 task done

meenbeese opened this issue Jan 21, 2024 · 3 comments

Closed

1 task done

Display a better message on missing song lyrics #1085

meenbeese opened this issue Jan 21, 2024 · 3 comments

Assignees

Labels

Contributor

meenbeese commented Jan 21, 2024

Is there an existing issue for this?

I have searched the existing issues

Pain

Users don't need to see an exception when lyrics for a song are not found, it is not a friendly UX.

Suggested solution

We should display a warning message (and not an exception) in a pleasant way and maybe direct them to other websites.

Useful resources

No response

Additional information

No response

meenbeese added the enhancement label

ninjakappa007 commented Jan 22, 2024

Hi ..
Can i take the issue .

prateek-lakhanpal commented Jan 22, 2024

Hi .. Can i take the issue .

go for it!

KRTirtho added this to Spotube Board

KRTirtho moved this to Backlog in Spotube Board

KRTirtho assigned ninjakappa007

KRTirtho added a commit that referenced this issue


          fix: better error message for failing to find lyrics #1085

e58e18d

Owner

KRTirtho commented Jan 23, 2024

@ninjakappa007 No worries amigo. I got it.

KRTirtho moved this from Backlog to Done in Spotube Board

KRTirtho added a commit that referenced this issue


          chore: show icon with error msg #1085

a6cb783

KRTirtho closed this as completed

KRTirtho moved this from Done to Deployed in Spotube Board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment