Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to match ranking #15

Open
kostmo opened this issue Jun 28, 2019 · 0 comments
Open

improvements to match ranking #15

kostmo opened this issue Jun 28, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kostmo
Copy link
Owner

kostmo commented Jun 28, 2019

  • A match closer to the end of the log should be given more weight
  • A literal match should outrank a regex match of the same length
    • Example from this group post refers to this build (scroll to bottom of match list):
      • Pattern 70, a regex with specificity 5, matches the string:
        ERROR: test_tracing_multiple_methods (__main__.TestScript)
      • However, pattern 34, a literal expression with specificity 4, is also an exact match. It should be considered the "best match" for this build breakage.

CC @ezyang

@kostmo kostmo added the enhancement New feature or request label Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant