From 413570338de0be57287beec3ab859c7602854e95 Mon Sep 17 00:00:00 2001
From: chikke srujan <121822803+srujanchikke@users.noreply.github.com>
Date: Wed, 10 Jan 2024 15:49:58 +0530
Subject: [PATCH 1/2] add validation for authtype and metadata in update
 payment connector

---
 crates/router/src/core/admin.rs | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs
index 2577bb83a3a..aae132fb347 100644
--- a/crates/router/src/core/admin.rs
+++ b/crates/router/src/core/admin.rs
@@ -1160,6 +1160,34 @@ pub async fn update_payment_connector(
             field_name: "connector_account_details".to_string(),
             expected_format: "auth_type and api_key".to_string(),
         })?;
+    let connector_name = mca.clone().connector_name;
+    let connector_enum = api_models::enums::Connector::from_str(&connector_name)
+        .into_report()
+        .change_context(errors::ApiErrorResponse::InvalidDataValue {
+            field_name: "connector",
+        })
+        .attach_printable_lazy(|| format!("unable to parse connector name {connector_name:?}"))?;
+    validate_auth_and_metadata_type(connector_enum, &auth, &req.metadata).map_err(
+        |err| match *err.current_context() {
+            errors::ConnectorError::InvalidConnectorName => {
+                err.change_context(errors::ApiErrorResponse::InvalidRequestData {
+                    message: "The connector name is invalid".to_string(),
+                })
+            }
+            errors::ConnectorError::InvalidConnectorConfig { config: field_name } => err
+                .change_context(errors::ApiErrorResponse::InvalidRequestData {
+                    message: format!("The {} is invalid", field_name),
+                }),
+            errors::ConnectorError::FailedToObtainAuthType => {
+                err.change_context(errors::ApiErrorResponse::InvalidRequestData {
+                    message: "The auth type is invalid for the connector".to_string(),
+                })
+            }
+            _ => err.change_context(errors::ApiErrorResponse::InvalidRequestData {
+                message: "The request body is invalid".to_string(),
+            }),
+        },
+    )?;
 
     let (connector_status, disabled) =
         validate_status_and_disabled(req.status, req.disabled, auth, mca.status)?;

From ab7d18c064dd4d9d04aa40a6c3b5cc992c62c9d5 Mon Sep 17 00:00:00 2001
From: chikke srujan <121822803+srujanchikke@users.noreply.github.com>
Date: Thu, 11 Jan 2024 20:23:39 +0530
Subject: [PATCH 2/2] minor refactor

---
 crates/router/src/core/admin.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs
index aae132fb347..3c10e3d8667 100644
--- a/crates/router/src/core/admin.rs
+++ b/crates/router/src/core/admin.rs
@@ -1160,8 +1160,8 @@ pub async fn update_payment_connector(
             field_name: "connector_account_details".to_string(),
             expected_format: "auth_type and api_key".to_string(),
         })?;
-    let connector_name = mca.clone().connector_name;
-    let connector_enum = api_models::enums::Connector::from_str(&connector_name)
+    let connector_name = mca.connector_name.as_ref();
+    let connector_enum = api_models::enums::Connector::from_str(connector_name)
         .into_report()
         .change_context(errors::ApiErrorResponse::InvalidDataValue {
             field_name: "connector",