-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[panic-persist] Implement compact version #12
Comments
If the error is a |
I like this idea, FWIW. |
@cr1901 The only problem with the extension |
By the time LTO has had its say in the applications I develop, the only panic sources are |
@jamesmunns Let me rephrase my previous comment. My theory is that even if libraries panic, the size of the applications where " There's no stable way to do this inline yet, but perhaps we could optionally extract the |
Right now,
panic-persist
stores a string, which can take a lot of space (kilobytes, potentially). It would be nice to have a version that just stores some kind of error code, or maybe a file/line number, perhaps tied to an enum, to reduce the required storage size down to just a few bytes.However, right now
panic
machinery is very string based, so I'm not sure how I would do it.Initial thoughts:
no_mangle
shenanigansstlog
, where strings are actually contained in the debug section, and just exist as an ID?panic
function that takes an enum instead? Maybe provide an extension trait forpersist_unwrap()
or something?The text was updated successfully, but these errors were encountered: